encoder: Add transliteration processor & help JavaDoc link updates #5815
+100
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
reviewed
Oct 18, 2024
...der/src/main/java/org/zaproxy/addon/encoder/processors/predefined/utility/Transliterate.java
Outdated
Show resolved
Hide resolved
addOns/encoder/src/main/javahelp/org/zaproxy/addon/encoder/resources/help/contents/encoder.html
Outdated
Show resolved
Hide resolved
- CHANGELOG.md > Add note. - EncodeDecodeProcessors > Register the new processor. - encoder.html > Add help content and behavior examples. (Update JavaDoc links to version 17 references.) - Messages.properties > Add key/value pair for the name. - Transliterate > New encoder. - TransliterateUnitTest > Unit Test for the new encoder. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
enc-translit
branch
from
544572c
to
f83c10f
Compare
kingthorin
changed the title
|
Fixed |
ricekot
reviewed
Oct 18, 2024
| @Override | ||
| protected String processInternal(String value) throws IOException { | ||
| // Normalize with compatible decomposition, then remove anything non-ASCII | ||
| return Normalizer.normalize(value, Normalizer.Form.NFKD).replaceAll("[^\\p{ASCII}]", ""); |
There was a problem hiding this comment.
Could also consider using the Apache commons util StringUtils#stripAccents (if it's already a dependency): https://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/StringUtils.html#stripAccents-java.lang.String-
There was a problem hiding this comment.
I did come across that when I was considering this but I didn't see any benefit vs the native impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
n/a
Checklist
./gradlew spotlessApplyfor code formatting