Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation: add a flag to enable/disable jobs #5820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dossantospat
Copy link

@dossantospat dossantospat commented Oct 16, 2024

Jobs with the enabled: false flag in the automation plan are not run. The flag can be toggled in the UI, either directly in the Automation Panel or through each job's individual dialog.

Overview

Briefly describe the purpose, goals, and changes or improvements made in this pull request.

Related Issues

Fix zaproxy/zaproxy#8626.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Jobs with the `enabled: false` flag in the automation plan are not run.
The flag can be toggled in the UI, either directly in the Automation
Panel or through each job's individual dialog.

Signed-off-by: Patrick Dos Santos <patrick.dos@protonmail.com>
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Posted by the CLA Assistant Lite bot.

@thc202 thc202 changed the title Added a flag to enable/disable jobs in the automation plan automation: add a flag to enable/disable jobs Oct 16, 2024
@thc202
Copy link
Member

thc202 commented Oct 16, 2024

through each job's individual dialog.

I don't think we should do that.

@dossantospat
Copy link
Author

This PR is linked to the issue on the zapproxy repository : zaproxy/zaproxy#8626

@dossantospat
Copy link
Author

through each job's individual dialog.

I don't think we should do that.

Your call, i can remove the checkbox in the jobs' dialogs. But it feels weird to me to edit part of the job in the dialog, and other parts in the panel's list.
I feel like I would want to be able to edit everything in the job's dialog if I have it opened.

@psiinon
Copy link
Member

psiinon commented Oct 16, 2024

I'm in 2 minds about the Enabled checkbox in the dialogs - I dont think we really need it, but I also think its a bit strange not being able to change everything via the dialog. If theres a consensus to keep it then the default sizes of many of the dialogs should be changed so that they display all of the fields correctly.
I think the Enabled checkboxes in the list work really well and are definitely very useful .. but I'd like them in the second column from the left 😁
The min/max yaml files should be changed as well as the help, which will then cause more of the existing tests to fail.
But all in all a very useful change - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adding a flag to enable/disable jobs in the automation plan
3 participants