Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send actions output to slogger #3164

Merged
merged 5 commits into from
Oct 31, 2024
Merged

feat: send actions output to slogger #3164

merged 5 commits into from
Oct 31, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Oct 30, 2024 •
edited
Loading

Description

Currently in the new output action commands won't go to stdout/stderr by default anymore since this was done with the spinner. Rather than output straight to stdout/stderr the new logger will include them in a log message.

Related Issue

Relates to #2576

Checklist before merging

@AustinAbro321
send actions to std
f6829e5 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 2fb6085
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6723c0679c59d80008396371

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/actions/actions.go 0.00% 16 Missing ⚠️
src/pkg/utils/exec/exec.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/utils/exec/exec.go 0.00% <0.00%> (ø)
src/pkg/packager/actions/actions.go 0.00% <0.00%> (ø)

@AustinAbro321
test if flakes
51e74e5 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
todo
19e07f0 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
change actions
96cb7aa 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
Merge branch 'main' into send-actions-to-std
2fb6085
@AustinAbro321 AustinAbro321 marked this pull request as ready for review October 31, 2024 17:39
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 31, 2024 17:39
@AustinAbro321 AustinAbro321 changed the title feat: send actions output to stdout/stderr feat: send actions output to new logger Oct 31, 2024
@AustinAbro321 AustinAbro321 changed the title feat: send actions output to new logger feat: send actions output to slogger Oct 31, 2024
mkcp
mkcp approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pkg/packager/actions/actions.go Show resolved Hide resolved
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 80eabd7 Oct 31, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the send-actions-to-std branch October 31, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @mkcp