⚡ Replace ESLint with Biome #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurzenika
approved these changes
Sep 20, 2024
| with: | ||
| title: Compressed Images Nightly | ||
| title: ':bento: Auto optimize images' |
There was a problem hiding this comment.
Suggested change
| title: ':bento: Auto optimize images' | |
| title: '🍱 Auto optimize images' |
utf-8 for the win
There was a problem hiding this comment.
Oh what's the diff? I'm used to using Gitmoji names rather than the character. Should it render everywhere utf8 works?
There was a problem hiding this comment.
emoji text doesn't render everything, you can use the same convention as gitmoji but with utf-8 unicode characters instead... then you don't have to teach your terminal to convert emoji text to utf-8 characters
There was a problem hiding this comment.
Actually GitHub supports them everywhere, that's why I thought it worked everywhere 😅
TIL, thanks!
yannbertrand
force-pushed
the
reset-ducks
branch
from
dfe0f49
to
9db6d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biome is way faster than ESLint which we almost don't use in this project. Adding it also provides a formater we can use with the
npm run formatcommand.Kept defaults Biome config, lots of changes are due to tabs over spaces.