Add my duck #369
Closed
Add my duck #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributors.js
Outdated
| @@ -23,4 +23,5 @@ const contributors = [ | |||
| { username: 'SameerKhans13', message: 'Happy Hacktoberfest-24 to all!' }, | |||
| { username: 'rishi-harti768', message: 'Happy Hacktoberfest guys! cheers'}, | |||
| { username: 'Hathaipach', message: 'Happy Hacktoberfest 2024'} | |||
| { username: 'Astro-Dude', message: 'print('Happy Hacktoberfest-24 to all!'); if (prMerged): print('Happy') else: print('please, accept')'} | |||
There was a problem hiding this comment.
Hello @Astro-Dude , I'm sorry but I can't accept this PR.
- your png file is not in the good directory
- line 25, you have to terminate this line with a comma,
- line 26, the json file is not valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here my contribution to "The Duck Gallery".
Thank you so much for creating such easy tasks for us beginners. Please accept my PR as well. Happy Hacktoberfest-24!
You must respect the following conditions
your-username.png)contributors.jsfile, the message must be short and respect the code of conductIf the PR doesn't respect those conditions, it will be closed