Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds error message for wrong input #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bertyruan
Copy link

  1. Incorrect spell input actions now updates error_message state
  2. UI displays error_message if it exists
  3. Changes the UI text from #fire-spell to #board. This fixes the incorrect CSS flex definition. The reason is CSS flex is defined on the parent property, not on children property. In this case, the board is the parent and the fire spells are the children.
  4. Adds an indent to the css spell properties for better UI.

changes

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @bertyruan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
59 33 12
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 17 37

@bertyruan
Copy link
Author

@kennithnichol @beneyal @wmporter @MattCSmith please review my PR, thanks 😄

@bertyruan
Copy link
Author

@kennithnichol @beneyal @wmporter @MattCSmith could you look at my pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant