Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] The implements of some v2 concepts for discuss only #457

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

halx99
Copy link

@halx99 halx99 commented Dec 23, 2021

CHANGES

  • Add length field and update length field at parse & setter time
  • All string getter/setter function use string_view_t
  • Add explicit boolean type for store bool value as string value true, false and avoid compiler ambiguous match const char_t* as scalar type 'bool'
  • Improve performance string literal value assignment with shallow copy support
  • Since getter function return string_view, if you needs get char_t* as 1.11.x, just invoke string_view::data(), it never return nullptr, this behavior same with v1.11.x

TODO:

  • Since setter is string_view, some tests can modify to use string_view literal svavoid strlen

sub pull-requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants