This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
WIP #151 - Add proper tests for http response codes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking @HcsOmot , this is still work in progress? |
|
@msvrtan yes, it's still WIP, sorry it's taking so long. Please give me a few more days. |
HcsOmot
force-pushed
the
151-proper-tests-for-http-response-codes
branch
2 times, most recently
from
f5f25b7
to
12d6644
Compare
- match NoEventsToRaffleException to HTTP response status 400
HcsOmot
force-pushed
the
151-proper-tests-for-http-response-codes
branch
from
12d6644
to
f553d32
Compare
msvrtan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making an API call without needed parameters
Backend will raise a DomainException
And HTTP response should have a corresponding response code
This will add behat tests for NoEventsToRaffleException which should cause HTTP 400 response
Closes #151