This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
[Behat] Update element count expectancies in tests #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're still dependant on the hardcoded values that represent various elements count that are being pulled from JoindIn - number of meetups, talks, and comments. This needs regular updates.
Phing strips default output coloring from commands it handles, and modifies the output formatting. PhpSpec, PhpStan, and Behat have flags that enable forced ANSI output. This makes the Phing's build output more user friendly.
Removed: - gecko-packages/gecko-php-unit (v3.0) Installed: - symfony/polyfill-ctype (v1.9.0) - doctrine/reflection (v1.0.0) - doctrine/event-manager (v1.0.0) - doctrine/persistence (v1.0.0) - composer/xdebug-handler (1.2.0) Updated: - symfony/flex (v1.0.49 => v1.0.89) - ocramius/package-versions (1.2.0 => 1.3.0) - paragonie/random_compat (v2.0.11 => v2.0.17) - symfony/templating (v3.4.2 => v3.4.14) - symfony/polyfill-mbstring (v1.6.0 => v1.9.0) - twig/twig (v2.4.4 => v2.5.0) - symfony/translation (v3.4.2 => v3.4.14) - symfony/validator (v3.4.2 => v3.4.14) - symfony/twig-bridge (v3.4.2 => v3.4.14) - symfony/polyfill-php70 (v1.6.0 => v1.9.0) - symfony/http-foundation (v3.4.2 => v3.4.14) - symfony/event-dispatcher (v3.4.2 => v3.4.14) - symfony/debug (v3.4.2 => v3.4.14) - symfony/http-kernel (v3.4.2 => v3.4.14) - symfony/filesystem (v3.4.2 => v3.4.14) - symfony/config (v3.4.2 => v3.4.14) - symfony/twig-bundle (v3.4.2 => v3.4.14) - symfony/inflector (v3.4.2 => v3.4.14) - symfony/property-access (v3.4.2 => v3.4.14) - symfony/polyfill-util (v1.6.0 => v1.9.0) - symfony/polyfill-php56 (v1.6.0 => v1.9.0) - symfony/security (v3.4.2 => v3.4.14) - symfony/dependency-injection (v3.4.2 => v3.4.14) - symfony/security-bundle (v3.4.2 => v3.4.14) - symfony/routing (v3.4.2 => v3.4.14) - symfony/finder (v3.4.2 => v3.4.14) - symfony/class-loader (v3.4.2 => v3.4.14) - symfony/polyfill-apcu (v1.6.0 => v1.9.0) - psr/simple-cache (1.0.0 => 1.0.1) - symfony/cache (v3.4.2 => v3.4.14) - symfony/framework-bundle (v3.4.2 => v3.4.14) - symfony/options-resolver (v3.4.2 => v3.4.14) - symfony/polyfill-intl-icu (v1.6.0 => v1.9.0) - symfony/intl (v3.4.2 => v3.4.14) - symfony/form (v3.4.2 => v3.4.14) - friendsofsymfony/user-bundle (v2.0.2 => v2.1.2) - guzzlehttp/guzzle (6.3.0 => 6.3.3) - twig/extensions (v1.5.1 => v1.5.2) - doctrine/inflector (v1.2.0 => v1.3.0) - doctrine/common (v2.8.1 => v2.9.0) - symfony/doctrine-bridge (v3.4.2 => v3.4.14) - symfony/asset (v3.4.2 => v3.4.14) - sensio/framework-extra-bundle (v5.1.3 => v5.2.0) - pagerfanta/pagerfanta (v1.0.5 => v1.1.0) - symfony/console (v3.4.2 => v3.4.14) - doctrine/dbal (v2.6.3 => v2.8.0) - doctrine/orm (v2.5.14 => v2.6.2) - doctrine/doctrine-cache-bundle (1.3.2 => 1.3.3) - doctrine/doctrine-bundle (1.8.1 => 1.9.1) - javiereguiluz/easyadmin-bundle (v1.17.7 => v1.17.12) - ramsey/uuid (3.7.1 => 3.8.0) - ramsey/uuid-doctrine (1.4.3 => 1.5.0) - symfony/expression-language (v3.4.2 => v3.4.14) - egulias/email-validator (2.1.3 => 2.1.5) - swiftmailer/swiftmailer (v6.0.2 => v6.1.2) - symfony/swiftmailer-bundle (v3.1.6 => v3.2.2) - symfony/dom-crawler (v3.4.2 => v3.4.14) - symfony/browser-kit (v3.4.2 => v3.4.14) - symfony/css-selector (v3.4.2 => v3.4.14) - behat/mink-browserkit-driver (v1.3.2 => 1.3.3) - symfony/yaml (v3.4.2 => v3.4.14) - behat/behat (v3.4.3 => v3.5.0) - behat/mink-extension (2.3.0 => 2.3.1) - behat/symfony2-extension (2.1.3 => 2.1.5) - symfony/stopwatch (v3.4.2 => v3.4.14) - symfony/process (v3.4.2 => v3.4.14) - symfony/polyfill-php72 (v1.6.0 => v1.9.0) - php-cs-fixer/diff (v1.2.0 => v1.3.0) - friendsofphp/php-cs-fixer (v2.9.0 => v2.12.2) - mockery/mockery (1.0 => 1.1.0) - phing/phing (2.16.0 => 2.16.1) - sebastian/comparator (2.1.0 => 2.1.3) - webmozart/assert (1.2.0 => 1.3.0) - phpdocumentor/reflection-docblock (4.2.0 => 4.3.0) - phpspec/prophecy (1.7.3 => 1.8.0) - phpspec/phpspec (4.2.5 => 4.3.1) - phpunit/phpunit-mock-objects (5.0.5 => 5.0.10) - phpunit/php-code-coverage (5.3.0 => 5.3.2) - myclabs/deep-copy (1.7.0 => 1.8.1) - phpunit/phpunit (6.5.5 => 6.5.11) - squizlabs/php_codesniffer (3.2.1 => 3.3.1) - symfony/dotenv (v3.4.2 => v3.4.14) - doctrine/data-fixtures (v1.3.0 => v1.3.1) - jean85/pretty-package-versions (1.0.3 => 1.2) - nette/php-generator (v3.0.1 => v3.0.5) - nette/di (v2.4.10 => v2.4.13) - nette/robot-loader (v3.0.2 => v3.0.4) - nikic/php-parser (v3.1.2 => v3.1.5) - zendframework/zend-eventmanager (3.2.0 => 3.2.1) - zendframework/zend-code (3.3.0 => 3.3.1) - doctrine/migrations (v1.6.2 => v1.8.1)
msvrtan
approved these changes
Aug 21, 2018
|
JoindIn seems to be a reliable source of truth, so I was thinking about refactoring the tests a bit - would it make sense to only check if all the events fetched from JoindIn are actually saved in dB, and not check the number of events retrieved? Otherwise we would need to somehow keep track of the number of events that are organized and compare that to the amount we get from JoindIn. |
|
Yeah, that sounds OK! |
New version of PHPCS deprecated some rules and introduced alternative ones, which caused PHPCS to fail while running checks and fixes.
In case FOS User manage can't load a user, trying to access it's password would raise an exception.
HcsOmot
force-pushed
the
maintenance/update-counters-in-tests
branch
from
e4d14d1
to
09a5fb8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still dependant on the hardcoded values that represent various
elements count that are being pulled from JoindIn - number of meetups,
talks, and comments. This needs regular updates.