feat/review spd json output - #45
Open
zhangweildlh wants to merge 3 commits into
Open
Conversation
zhangweildlh
commented
Jul 30, 2026
zhangweildlh
commented
- feat(review-spd): add structured JSON output compatible with open-code-review-delegate
- fix(review-spd): align JSON output with open-code-review-delegate downstream schema
…e-review-delegate - Phase 6 now emits both findings-first text and a structured JSON block - Add reviewer-focus -> JSON category mapping (Correctness/Regression -> bug, Tests -> test, Security -> security, Performance -> performance) - output-format.md gains Severity Rollup + Structured JSON schema mirroring open-code-review-delegate - Enables Agent consumption and downstream tooling without changing the existing text report
…nstream schema - M1: JSON mode now uses ocr-compatible values (workspace/range/commit); drop separate branch mode - M2: rules[] now carries rule field; document path_pattern intentionally absent (downstream tolerate) - L3: document start_line/end_line source = diff hunk line numbers (matches text file:line) - L4: Severity Rollup low no longer hunts style; consistent with findings-first discipline - L5: document category limited to 5 values by design; downstream should tolerate
…ranch from/to, add JSON consistency example - L1: output-format.md Severity Rollup now references SKILL.md Phase 5 as the authoritative severity definition, removing the medium/low wording fork. - L2: branch mode JSON target.from = base, target.to = head, aligned with review-context.py base/head. - M1: Structured JSON section gains a text<->JSON consistency example proving the Phase 6 same-findings-list discipline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.