Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear combo timer only when affected keys are released #2494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ssbb
Copy link

@ssbb ssbb commented Sep 22, 2024

Now, the key release listener checks if the released key is part of any combo candidate or active combo, instead of stopping the combo timer on any key release.

I also had to modify the tap-dance/3b-tap-int-seq test because it relied on the old combo release behavior, but I would like to double-check if this is the behavior we want to maintain.

Fixes #2378

@ssbb ssbb requested a review from a team as a code owner September 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing other key in middle of the combo breaks the combo trigger
2 participants