feat: Added toggle-mode, allowing toggle-on and toggle-off
#2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Munnich
force-pushed
the
toggle-mode
branch
from
63bb371
to
e668edd
Compare
Yeah, I was just thinking that. Going to do so (and fix an oopsie I noticed) and then undraft. |
Nick-Munnich
force-pushed
the
toggle-mode
branch
from
e668edd
to
c8ddadf
Compare
…explicitly toggle on or toggle off.
Nick-Munnich
force-pushed
the
toggle-mode
branch
from
c8ddadf
to
4ac5b3c
Compare
caksoylar
reviewed
Oct 21, 2024
There was a problem hiding this comment.
https://zmk.dev/docs/config/behaviors needs to be updated as well.
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
caksoylar
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
toggle-modeflag to both the key toggle and toggle layer behaviors. Toggle mode can be set toTested locally with basic functionality. I don't see an edge case where this might cause issues.
Note that if key toggle on is spammed, it will repeatedly send over the "press" code.
Resolves #2523.