Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add studio metadata feature #2561

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add studio metadata feature #2561

merged 2 commits into from
Oct 17, 2024

Conversation

petejohanson
Copy link
Contributor

Add a new studio option to the features list in our metadata files to indicate the board/shield supports ZMK Studio.

@petejohanson petejohanson added the studio ZMK Studio (runtime keymaps) label Oct 17, 2024
@petejohanson petejohanson self-assigned this Oct 17, 2024
@petejohanson petejohanson requested a review from a team as a code owner October 17, 2024 00:02
@caksoylar
Copy link
Contributor

Missing keyboards I found:

  • planck_rev6
  • preonic_rev3
  • kbdfans_tofu65_v2
  • contra
  • m60
  • boardsource5x12

@petejohanson
Copy link
Contributor Author

Missing keyboards I found:

* `planck_rev6`

* `preonic_rev3`

* `kbdfans_tofu65_v2`

* `contra`

* `m60`

* `boardsource5x12`

Thanks. Strictly speaking, the preonic and planck I think need tweaks to enable settings subsystem to fully work with Studio, so I'll skip those for now.

@Nick-Munnich
Copy link
Contributor

Add it to the relevant docs page?

@petejohanson
feat: Add studio as a feature option in metadata
13c55dd 
* Allow boards/shields to indicate ZMK Studio support in the `features` list.
@petejohanson
chore: Tag studio enabled boards/shields.
10c7bdf
@petejohanson petejohanson requested a review from a team as a code owner October 17, 2024 00:25
@petejohanson
Copy link
Contributor Author

Add it to the relevant docs page?

Added. Thanks.

Nick-Munnich
Nick-Munnich approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Nick-Munnich Nick-Munnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petejohanson petejohanson merged commit 10868c7 into zmkfirmware:main Oct 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nick-Munnich Nick-Munnich Nick-Munnich approved these changes

Assignees

@petejohanson petejohanson

Labels
studio ZMK Studio (runtime keymaps)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petejohanson @caksoylar @Nick-Munnich