Triangulate backward compatibility check commands #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshnikam671
changed the title
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
from
17ec532
to
7962cc1
Compare
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
from
9f6610e
to
69dcc3d
Compare
yogeshnikam671
commented
Aug 26, 2024
application/src/main/kotlin/application/BackwardCompatibilityCheckCommand.kt
Outdated
Show resolved
Hide resolved
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
3 times, most recently
from
59887e6
to
bd50941
Compare
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
from
bd50941
to
63e0403
Compare
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
from
63e0403
to
adcc2dd
Compare
Abstract out the common logic in backward-compatibility-check command
…ommand which can let us run the check on a specific folder or file in a repository
…ince the logic is reusable.
…ompatibilityCheckCommand
Add deprecation notice to all the b/w compatibility related commands which will be eventually removed
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
from
b6fbbce
to
827a305
Compare
…l bring the repository back to the original state if the command is aborted in between
…d unnecessary logs in the backward compatibility check result logs
…le override in sub-classes of BackwardCompatibilityCheckBaseCommand
yogeshnikam671
commented
Oct 11, 2024
application/src/main/kotlin/application/BackwardCompatibilityCheckCommand.kt
Outdated
Show resolved
Hide resolved
yogeshnikam671
commented
Oct 11, 2024
...n/src/main/kotlin/application/backwardCompatibility/BackwardCompatibilityCheckBaseCommand.kt
Outdated
Show resolved
Hide resolved
yogeshnikam671
force-pushed
the
triangulate_bcc_commands
branch
from
dd5b2b5
to
9b37ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Created an abstract class which has the common logic around backward compatibility check. This helps reuse the logic in other protocols easily.
Checklist: