Pulling in changes which were developed during the file format development. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to while eliminate range object generation
PepperJo
reviewed
Apr 18, 2018
| affixByteArray(random.nextInt(size)) = random.nextPrintableChar().toByte | ||
| /* now we copy affix array */ | ||
| Array.copy(affixByteArray, 0, toReturn, 0, size) | ||
| this.baseRandomArray(ThreadLocalRandom.current().nextInt(toCopy)) = scalaRandom.nextPrintableChar().toByte |
There was a problem hiding this comment.
what if we randomly get the same byte? shouldn't we try until it changes?
| } | ||
| /* just randomly change 1 byte - this is to make sure parquet | ||
| * does not ignore the data - char will be casted to byte */ | ||
| affixByteArray(random.nextInt(size)) = random.nextPrintableChar().toByte |
| val inputRDD = spark.sparkContext.parallelize(0 until options.getTasks, options.getTasks) | ||
| require(rowsPerTask <= Integer.MAX_VALUE) | ||
| if(options.getClassName.equalsIgnoreCase("ParquetExample")){ | ||
| doParquetExample(spark, inputRDD, rowsPerTask.toInt, options) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.