Handle generating primitive types as responses #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
reviewed
Aug 22, 2024
Comment on lines
+353
to
+361
| if ( | ||
| distinctTypes->Set.size === 0 || | ||
| !( | ||
| distinctTypes | ||
| ->Set.values | ||
| ->Iterator.toArrayWithMapper(t => String.includes(t, "response")) | ||
| ->Array.includes(true) | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
Could you add a little comment about the logic here and why it is like it is?
There was a problem hiding this comment.
How does that sound?
zth
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
This is awesome, nice work!
- Would you add a CHANGELOG?
- I suspect this fixes Returning just a bool does not yield proper result #12 as well. To verify, could you also add tests for: bool and string? Then we know we're covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.