Run shared RP automation using container and Makefile #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razo7
force-pushed
the
automate-shared-rp
branch
2 times, most recently
from
b884d3b
to
0e86bc2
Compare
|
Please rebase pull request. |
razo7
force-pushed
the
automate-shared-rp
branch
from
0e86bc2
to
40250d3
Compare
Follow tutorial logic and run it in a container
Use 'log', fix env file, bash linting and better cleanup
razo7
changed the title
razo7
commented
Oct 1, 2024
Comment on lines
+306
to
+307
| # TODO: How to get the PULL_SECRET - We can pass it to the container... | ||
| # TODO: How to get the USER_PULL_SECRET |
There was a problem hiding this comment.
This has to be investigated, as for now it uses a dummy variables.
razo7
force-pushed
the
automate-shared-rp
branch
from
40250d3
to
a7ec53c
Compare
razo7
commented
Oct 1, 2024
Comment on lines
+184
to
+190
| log "Admin-consent premission $permission_id" | ||
| log -n "Are you admin? (y/N): " | ||
| read answer | ||
| if [[ "$answer" == "y" ]]; then | ||
| az ad app permission admin-consent \ | ||
| --id "$AZURE_CLIENT_ID" |
There was a problem hiding this comment.
Consider adding user input here or at the beginning of the automation to continue with or without this consent.
razo7
force-pushed
the
automate-shared-rp
branch
from
a7ec53c
to
fbdeb5e
Compare
|
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-7754
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?