Fix crash with duplicate paths #4896
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
You may test this build by running Add the following CLI flags
Or with all autorest --version:http://tinyurl.com/23rkx3vs --use:http://tinyurl.com/25gl42t3or use the following in your autorest configuration: # For changes to autorest core
version: "http://tinyurl.com/23rkx3vs"
# For changes to modelerfour
use-extension:
"@autorest/modelerfour": "http://tinyurl.com/25gl42t3"If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it. |
| @@ -351,7 +351,9 @@ async function main() { | |||
| // - doing the inversion (instanceof Error) doesn't reliably work since that seems to return false on Errors marshalled from safeEval | |||
| if (e instanceof Exception) { | |||
| logger.log({ level: "error", message: e.message }); | |||
| exitCode = e.exitCode; | |||
| if (e.exitCode) { | |||
There was a problem hiding this comment.
@timotheeguerin: Can you explain why this check is needed? Might be obvious but I don't see it.
fix #4882 too