Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Nodeclaim/Machine provision to RAG Engine controller #616

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Oct 8, 2024

Reason for Change:

  1. add Nodeclaim/Machine provision to RAG Engine controller
  2. add status changes to RAG Engine controller
  3. change the corresponding webhook, tests and so on
  4. reorg the duplicate codes between RAG Engine and workspace

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 43.18707% with 246 lines in your changes missing coverage. Please review.

Project coverage is 53.43%. Comparing base (5c30038) to head (e06afb7).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/ragengine_controller.go 27.67% 150 Missing and 12 partials ⚠️
pkg/nodeclaim/nodeclaim.go 63.49% 23 Missing ⚠️
pkg/machine/machine.go 64.00% 18 Missing ⚠️
api/v1alpha1/ragenging_validation.go 0.00% 14 Missing ⚠️
pkg/webhooks/webhooks.go 0.00% 14 Missing ⚠️
pkg/controllers/workspace_controller.go 58.62% 12 Missing ⚠️
pkg/controllers/ragengine_status.go 94.73% 1 Missing and 1 partial ⚠️
api/v1alpha1/ragengine_default.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   58.18%   53.43%   -4.75%     
==========================================
  Files          30       34       +4     
  Lines        2987     3503     +516     
==========================================
+ Hits         1738     1872     +134     
- Misses       1149     1517     +368     
- Partials      100      114      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bangqi Zhu added 5 commits October 8, 2024 15:34
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
return reconcile.Result{}, nil
}

// applyRAGEngineResource applies RAGEngine resource spec.
func (c *RAGEngineReconciler) applyRAGEngineResource(ctx context.Context, ragEngineObj *kaitov1alpha1.RAGEngine) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants