Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Nodeclaim/Machine provision to RAG Engine controller #616

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Merge branch 'main' into bangqipropel/Nodeprovision_RAG

e06afb7
Select commit
Loading
Failed to load commit list.
Open

feat: add Nodeclaim/Machine provision to RAG Engine controller #616

Merge branch 'main' into bangqipropel/Nodeprovision_RAG
e06afb7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 8, 2024 in 0s

53.43% (-4.75%) compared to 5c30038

View this Pull Request on Codecov

53.43% (-4.75%) compared to 5c30038

Details

Codecov Report

Attention: Patch coverage is 43.18707% with 246 lines in your changes missing coverage. Please review.

Project coverage is 53.43%. Comparing base (5c30038) to head (e06afb7).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/ragengine_controller.go 27.67% 150 Missing and 12 partials ⚠️
pkg/nodeclaim/nodeclaim.go 63.49% 23 Missing ⚠️
pkg/machine/machine.go 64.00% 18 Missing ⚠️
api/v1alpha1/ragenging_validation.go 0.00% 14 Missing ⚠️
pkg/webhooks/webhooks.go 0.00% 14 Missing ⚠️
pkg/controllers/workspace_controller.go 58.62% 12 Missing ⚠️
pkg/controllers/ragengine_status.go 94.73% 1 Missing and 1 partial ⚠️
api/v1alpha1/ragengine_default.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   58.18%   53.43%   -4.75%     
==========================================
  Files          30       34       +4     
  Lines        2987     3503     +516     
==========================================
+ Hits         1738     1872     +134     
- Misses       1149     1517     +368     
- Partials      100      114      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov