Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update RAG Status #621

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat: Update RAG Status #621

merged 2 commits into from
Oct 10, 2024

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Oct 9, 2024 •
edited
Loading

Reason for Change:
Update RAG Status and the unit tests

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (5c30038) to head (5000a3a).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   58.18%   54.80%   -3.38%     
==========================================
  Files          30       34       +4     
  Lines        2987     3235     +248     
==========================================
+ Hits         1738     1773      +35     
- Misses       1149     1356     +207     
- Partials      100      106       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Clusterrole and webhook update
cf603bc 
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
RAG Status Update
5000a3a 
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@Fei-Guo Fei-Guo merged commit 1818551 into main Oct 10, 2024
6 of 8 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/RAG_status branch October 10, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuangqh zhuangqh zhuangqh approved these changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bangqipropel @zhuangqh @Fei-Guo