Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network fidelity #158

Merged
merged 14 commits into from
Jul 30, 2024
Merged

Network fidelity #158

merged 14 commits into from
Jul 30, 2024

Conversation

i-am-sijia
Copy link
Collaborator

@i-am-sijia i-am-sijia commented Jul 8, 2024

What existing problem does the pull request solve and why should we include it?

The network fidelity task in task order 5 proposed to use FT based filters to create TAZ drive network, instead of using the assignable based filters. This would require:

What is the testing plan?

Demonstrate the code is solid by discussing how results are verified and covered by tests

  • Code for this PR is covered in tests
  • Code passes all existing tests

Code formatting

Code should be PEP8 compliant before merging by running a package like black

  • Code linted

Applicable Issues

Issues List

Closes #147

@i-am-sijia i-am-sijia linked an issue Jul 11, 2024 that may be closed by this pull request
9 tasks
@i-am-sijia i-am-sijia marked this pull request as ready for review July 30, 2024 23:19
@i-am-sijia i-am-sijia merged commit 172a183 into develop Jul 30, 2024
0 of 2 checks passed
@i-am-sijia i-am-sijia deleted the network-fidelity branch July 30, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Reduce Fidelity of the Roadway Network - Phase I
2 participants