Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transactionButton component to handle wallet connection and transaction sending #161

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

luchobonatti
Copy link
Collaborator

@luchobonatti luchobonatti commented Jul 8, 2024

Closes #160

Description:

This pull request fixes the TransactionButton component to properly handle wallet connection and transaction sending. The changes include:

  • Removing unused imports and variables

  • Updating the useWeb3Status hook to use the new useWeb3StatusConnected hook

  • Refactoring the TransactionButton component to remove unnecessary code and improve readability

  • adds new WalletStatusVerifier Component and HoC

Steps:

(Required steps to reproduce or test the fix / feature)

Type of change:

  • New feature
  • Bug fix
  • Breaking change
  • Enhancement
  • Refactoring
  • Chore

How Has This Been Tested?

  • Manual testing
  • Automated tests
  • Other (explain)

Remember to check that:

  • Your code follows the style guidelines of this project
  • You have performed a self-review of your code
  • You have commented your code in hard-to-understand areas
  • You have made corresponding changes to the documentation
  • Your changes generate no new warnings

Screenshots

(Add screenshots or videos to help test this pull request)

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dappbooster ✅ Ready (Inspect) Visit Preview Jul 8, 2024 4:53pm

@luchobonatti luchobonatti changed the title Fix TransactionButton component to handle wallet connection and transaction sending fix: transactionButton component to handle wallet connection and transaction sending Jul 8, 2024
@luchobonatti luchobonatti self-assigned this Jul 8, 2024
Copy link
Member

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 💋

src/hooks/useWeb3Status.tsx Outdated Show resolved Hide resolved
Co-authored-by: Fernando Greco <fernando.greco@gmail.com>
@gabitoesmiapodo gabitoesmiapodo merged commit d19eb70 into main Jul 8, 2024
2 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the feat/160 branch July 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WalletStatusVerifier component and HoC
3 participants