-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cognito Tokens using SecretsManager #452
base: develop
Are you sure you want to change the base?
Conversation
Merging to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I won't approve for merge, since there are some other parts, I want this in too.
And I want to merge this after save and search work, so tests continue to be green.
@@ -1,7 +1,7 @@ | |||
# CRIPT DEVELOPMENT TEAM | |||
|
|||
- [Navid Hariri](https://github.com/nh916) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Navid did contribute, any reason we should remove him?
@@ -23,20 +24,18 @@ concurrency: | |||
# Cancel in-progress runs when a new workflow with the same group name is triggered | |||
cancel-in-progress: true | |||
|
|||
env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Fixed CI