Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cognito Tokens using SecretsManager #452

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/workflows/test_coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- main
- develop
- trunk-merge/**
- pipeline/*
pull_request:
branches:
- main
Expand All @@ -23,20 +24,18 @@ concurrency:
# Cancel in-progress runs when a new workflow with the same group name is triggered
cancel-in-progress: true

env:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}

jobs:
test-coverage:
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest]
python-version: [3.12]

env:
CRIPT_HOST: https://lb-stage.mycriptapp.org/
CRIPT_TOKEN: 125433546
CRIPT_STORAGE_TOKEN: 987654321
CRIPT_TESTS: False

steps:
- uses: actions/checkout@v4

Expand All @@ -54,5 +53,16 @@ jobs:
- name: Install requirements_dev.txt
run: pip install -r requirements_dev.txt

- name: Retrieve Cognito Tokens from AWS Secrets Manager
run: |
echo "CRIPT_TOKEN=$(aws secretsmanager get-secret-value --secret-id Pipelines_CognitoAccessToken --query SecretString --output text)" >> $GITHUB_ENV
echo "CRIPT_STORAGE_TOKEN=$(aws secretsmanager get-secret-value --secret-id Pipelines_CognitoIdToken --query SecretString --output text)" >> $GITHUB_ENV

- name: Test Coverage

run: pytest --cov --cov-fail-under=85
env:
CRIPT_HOST: https://lb-stage.mycriptapp.org/
CRIPT_TOKEN: ${{ env.CRIPT_TOKEN }}
CRIPT_STORAGE_TOKEN: ${{ env.CRIPT_STORAGE_TOKEN }}
CRIPT_TESTS: True
4 changes: 2 additions & 2 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# CRIPT DEVELOPMENT TEAM

- [Navid Hariri](https://github.com/nh916)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navid did contribute, any reason we should remove him?

- [Ludwig Schneider](https://github.com/InnocentBug/)
- [Dylan Walsh](https://github.com/dylanwal/)
- [Brillant Kasami](https://github.com/brili)
- [Brilant Kasami](https://github.com/brili)
- [Izaim Osmani](https://github.com/izaim)
- [Fatjon Ismailaj](https://github.com/fatjon95)
Loading