Update to 1.0.1 #454
Update to 1.0.1 #454
Conversation
|
Merging to
|
| @@ -122,7 +122,7 @@ def complex_property_node(complex_material_node, complex_condition_node, complex | |||
| a maximal property sub-object with all possible fields filled | |||
| """ | |||
| my_complex_property = cript.Property( | |||
| key="modulus_shear", | |||
There was a problem hiding this comment.
how did you know to change this keyword ?
was this info from an error message like in the error message for model 1.0.0?
| @@ -25,7 +25,7 @@ def simple_project_node(simple_collection_node) -> cript.Project: | |||
| def complex_project_dict(complex_collection_node, simple_material_node, complex_user_node) -> dict: | |||
| project_dict = {"node": ["Project"]} | |||
| project_dict["locked"] = True | |||
| project_dict["model_version"] = "1.0.0" | |||
| project_dict["model_version"] = "1.0.1" | |||
There was a problem hiding this comment.
I would advise you dont pin the model_version to a specific version as it is populated automatically on the latest version.
There was a problem hiding this comment.
great idea, how do we know which one is the newest version?
There was a problem hiding this comment.
also this is probably only a work around.
We need a general scheme to update nodes from one version to the newest version automatically.
In this case this is very simple, but it can get more complicated easily.
Do you have ideas how this can be done?
I was thinking something along the Go philosophy that any change needs to have an automatic port option.
Otherwise we will have nodes that we can't process anymore since they are going out of date.
There was a problem hiding this comment.
You can get the latest version from the /schema endpoint at `#/defs/ModelVersion", but I think you are looking too much into it, I think the datamodel as of now wont have major changes that will need transformations, the only changes that will be periodical is from the controlled vocabulary which is also embedded in the jsonschema hence bumping the version number. It should work fine if you remove the model_version attribute altogether.
There was a problem hiding this comment.
can you approve pls
No description provided.