Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.0.1 #454

Closed
wants to merge 6 commits into from
Closed

Update to 1.0.1 #454

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78fbdea
Update to 1.0.1
InnocentBug Apr 24, 2024
0c01e51
update python version
InnocentBug Apr 24, 2024
63e2e99
run new version on 3.9
InnocentBug Apr 24, 2024
ce28a85
3.10
InnocentBug Apr 24, 2024
c86e042
fix oversight
InnocentBug Apr 24, 2024
6b06b8c
fixing docs
InnocentBug Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

matrix:
os: [ubuntu-latest, macos-latest]
python-version: [3.8, 3.12]
python-version: ["3.10", 3.12]

env:
CRIPT_HOST: https://lb-stage.mycriptapp.org/
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[![License](./CRIPT_full_logo_colored_transparent.png)](https://github.com/C-Accel-CRIPT/Python-SDK/blob/develop/LICENSE.md)

[![License](https://img.shields.io/github/license/C-Accel-CRIPT/cript?style=flat-square)](https://github.com/C-Accel-CRIPT/Python-SDK/blob/develop/LICENSE.md)
[![Python](https://img.shields.io/badge/Language-Python%203.8+-blue?style=flat-square&logo=python)](https://www.python.org/)
[![Python](https://img.shields.io/badge/Language-Python%203.10+-blue?style=flat-square&logo=python)](https://www.python.org/)
[![Code style is black](https://img.shields.io/badge/Code%20Style-black-000000.svg?style=flat-square&logo=python)](https://github.com/psf/black)
[![Link to CRIPT website](https://img.shields.io/badge/platform-criptapp.org-blueviolet?style=flat-square)](https://criptapp.org/)
[![Using Pytest](https://img.shields.io/badge/Dependencies-pytest-green?style=flat-square&logo=Pytest)](https://docs.pytest.org/en/7.2.x/)
Expand Down Expand Up @@ -36,7 +36,7 @@ The CRIPT Python SDK allows programmatic access to the [CRIPT platform](https://

## Installation

CRIPT Python SDK requires Python 3.8+
CRIPT Python SDK requires Python 3.10+

The latest released of CRIPT Python SDK is available on [Python Package Index (PyPI)](https://pypi.org/project/cript/)

Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ classifiers =
Topic :: Scientific/Engineering
Programming Language :: Python :: 3
Programming Language :: Python :: 3 :: Only
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.10

[options]
package_dir =
=src
packages = find:
python_requires = >=3.8
python_requires = >=3.10
include_package_data = True
install_requires =
requests==2.31.0
Expand Down
12 changes: 6 additions & 6 deletions tests/fixtures/primary_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def simple_project_node(simple_collection_node) -> cript.Project:
def complex_project_dict(complex_collection_node, simple_material_node, complex_user_node) -> dict:
project_dict = {"node": ["Project"]}
project_dict["locked"] = True
project_dict["model_version"] = "1.0.0"
project_dict["model_version"] = "1.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advise you dont pin the model_version to a specific version as it is populated automatically on the latest version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, how do we know which one is the newest version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this is probably only a work around.

We need a general scheme to update nodes from one version to the newest version automatically.

In this case this is very simple, but it can get more complicated easily.

Do you have ideas how this can be done?

I was thinking something along the Go philosophy that any change needs to have an automatic port option.
Otherwise we will have nodes that we can't process anymore since they are going out of date.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get the latest version from the /schema endpoint at `#/defs/ModelVersion", but I think you are looking too much into it, I think the datamodel as of now wont have major changes that will need transformations, the only changes that will be periodical is from the controlled vocabulary which is also embedded in the jsonschema hence bumping the version number. It should work fine if you remove the model_version attribute altogether.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you approve pls

project_dict["updated_by"] = json.loads(copy.deepcopy(complex_user_node).get_expanded_json())
project_dict["created_by"] = json.loads(complex_user_node.get_expanded_json())
project_dict["public"] = True
Expand Down Expand Up @@ -60,7 +60,7 @@ def fixed_cyclic_project_node() -> cript.Project:
project_json_string += '"created_at": "2024-03-12 15:58:12.486673",\n'
project_json_string += '"updated_at": "2024-03-12 15:58:12.486681",\n'
project_json_string += '"email": "test@emai.com",\n'
project_json_string += '"model_version": "1.0.0",\n'
project_json_string += '"model_version": "1.0.1",\n'
project_json_string += '"orcid": "0000-0002-0000-0000",\n'
project_json_string += '"picture": "/my/picture/path",\n'
project_json_string += '"username": "testuser"\n'
Expand All @@ -72,13 +72,13 @@ def fixed_cyclic_project_node() -> cript.Project:
project_json_string += '"created_at": "2024-03-12 15:58:12.486673",\n'
project_json_string += '"updated_at": "2024-03-12 15:58:12.486681",\n'
project_json_string += '"email": "test@emai.com",\n'
project_json_string += '"model_version": "1.0.0",\n'
project_json_string += '"model_version": "1.0.1",\n'
project_json_string += '"orcid": "0000-0002-0000-0000",\n'
project_json_string += '"picture": "/my/picture/path",\n'
project_json_string += '"username": "testuser"\n'
project_json_string += "},\n"
project_json_string += '"locked": true,\n'
project_json_string += '"model_version": "1.0.0",\n'
project_json_string += '"model_version": "1.0.1",\n'
project_json_string += '"public": true,\n'
project_json_string += '"name": "my project name",\n'
project_json_string += '"notes": "my project notes",\n'
Expand Down Expand Up @@ -126,7 +126,7 @@ def fixed_cyclic_project_node() -> cript.Project:
project_json_string += '"node": ["Property"],\n'
project_json_string += '"uid": "_:fc504202-6fdd-43c7-830d-40c7d3f0cb8c",\n'
project_json_string += '"uuid": "fc504202-6fdd-43c7-830d-40c7d3f0cb8c",\n'
project_json_string += '"key": "modulus_shear",\n'
project_json_string += '"key": "enthalpy",\n'
project_json_string += '"type": "value",\n'
project_json_string += '"value": 5.0,\n'
project_json_string += '"unit": "GPa",\n'
Expand Down Expand Up @@ -213,7 +213,7 @@ def fixed_cyclic_project_node() -> cript.Project:
project_json_string += '"node": ["Property"],\n'
project_json_string += '"uid": "_:fde629f5-8d3a-4546-8cd3-9de63b990187",\n'
project_json_string += '"uuid": "fde629f5-8d3a-4546-8cd3-9de63b990187",\n'
project_json_string += '"key": "modulus_shear",\n'
project_json_string += '"key": "enthalpy",\n'
project_json_string += '"type": "value",\n'
project_json_string += '"value": 5.0,\n'
project_json_string += '"unit": "GPa",\n'
Expand Down
8 changes: 4 additions & 4 deletions tests/fixtures/subobjects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def complex_property_node(complex_material_node, complex_condition_node, complex
a maximal property sub-object with all possible fields filled
"""
my_complex_property = cript.Property(
key="modulus_shear",
Copy link

@duboyal duboyal Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you know to change this keyword ?
was this info from an error message like in the error message for model 1.0.0?

key="enthalpy",
type="value",
value=5.0,
unit="GPa",
Expand All @@ -144,7 +144,7 @@ def complex_property_node(complex_material_node, complex_condition_node, complex
def complex_property_dict(complex_material_node, complex_condition_dict, complex_citation_dict, complex_data_node, simple_process_node, simple_computation_node) -> dict:
ret_dict = {
"node": ["Property"],
"key": "modulus_shear",
"key": "enthalpy",
"type": "value",
"value": 5.0,
"unit": "GPa",
Expand All @@ -165,7 +165,7 @@ def complex_property_dict(complex_material_node, complex_condition_dict, complex
@pytest.fixture(scope="function")
def simple_property_node() -> cript.Property:
my_property = cript.Property(
key="modulus_shear",
key="enthalpy",
type="value",
value=5.0,
unit="GPa",
Expand All @@ -177,7 +177,7 @@ def simple_property_node() -> cript.Property:
def simple_property_dict() -> dict:
ret_dict = {
"node": ["Property"],
"key": "modulus_shear",
"key": "enthalpy",
"type": "value",
"value": 5.0,
"unit": "GPa",
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/supporting_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def complex_local_file_node(tmp_path_factory) -> cript.File:
def complex_user_dict() -> dict:
user_dict = {"node": ["User"]}
user_dict["created_at"] = str(datetime.datetime.now())
user_dict["model_version"] = "1.0.0"
user_dict["model_version"] = "1.0.1"
user_dict["picture"] = "/my/picture/path"
user_dict["updated_at"] = str(datetime.datetime.now())
user_dict["username"] = "testuser"
Expand Down
2 changes: 1 addition & 1 deletion tests/nodes/primary_nodes/test_material.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_create_complex_material(cript_api, simple_material_node, simple_computa
component = [simple_material_node]
forcefield = simple_computational_forcefield_node

my_property = [cript.Property(key="modulus_shear", type="min", value=1.23, unit="gram")]
my_property = [cript.Property(key="rho_z", type="min", value=1.23, unit="gram")]

my_material = cript.Material(
name=material_name,
Expand Down
4 changes: 2 additions & 2 deletions tests/nodes/subobjects/test_property.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def test_json(complex_property_node, complex_property_dict):


def test_setter_getter(complex_property_node, simple_material_node, simple_process_node, complex_condition_node, simple_data_node, simple_computation_node, complex_citation_node):
complex_property_node.key = "modulus_loss"
assert complex_property_node.key == "modulus_loss"
complex_property_node.key = "rho_z"
assert complex_property_node.key == "rho_z"

complex_property_node.type = "min"
assert complex_property_node.type == "min"
Expand Down
12 changes: 6 additions & 6 deletions tests/test_node_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def test_uid_deserialization(simple_algorithm_node, complex_parameter_node, simp
material = cript.Material(name="my material", bigsmiles="{[][$]CC[$][]}")

computation = cript.Computation(name="my computation name", type="analysis")
property1 = cript.Property("modulus_shear", "value", 5.0, "GPa", computation=[computation])
property2 = cript.Property("modulus_loss", "value", 5.0, "GPa", computation=[computation])
property1 = cript.Property("enthalpy", "value", 5.0, "GPa", computation=[computation])
property2 = cript.Property("rho_z", "value", 5.0, "GPa", computation=[computation])
material.property = [property1, property2]

material2 = cript.load_nodes_from_json(material.json)
Expand All @@ -50,7 +50,7 @@ def test_uid_deserialization(simple_algorithm_node, complex_parameter_node, simp
"node": ["Property"],
"uid": "_:82e7270e-9f35-4b35-80a2-faa6e7f670be",
"uuid": "82e7270e-9f35-4b35-80a2-faa6e7f670be",
"key": "modulus_shear",
"key": "enthalpy",
"type": "value",
"value": 5.0,
"unit": "GPa",
Expand All @@ -60,7 +60,7 @@ def test_uid_deserialization(simple_algorithm_node, complex_parameter_node, simp
"node": ["Property"],
"uid": "_:fc4dfa5e-742c-4d0b-bb66-2185461f4582",
"uuid": "fc4dfa5e-742c-4d0b-bb66-2185461f4582",
"key": "modulus_loss",
"key": "rho_z",
"type": "value",
"value": 5.0,
"unit": "GPa",
Expand Down Expand Up @@ -92,7 +92,7 @@ def test_uid_deserialization(simple_algorithm_node, complex_parameter_node, simp
# ],
# "uid": "_:82e7270e-9f35-4b35-80a2-faa6e7f670be",
# "uuid": "82e7270e-9f35-4b35-80a2-faa6e7f670be",
# "key": "modulus_shear",
# "key": "enthalpy",
# "type": "value",
# "value": 5.0,
# "unit": "GPa",
Expand All @@ -111,7 +111,7 @@ def test_uid_deserialization(simple_algorithm_node, complex_parameter_node, simp
# ],
# "uid": "_:fc4dfa5e-742c-4d0b-bb66-2185461f4582",
# "uuid": "fc4dfa5e-742c-4d0b-bb66-2185461f4582",
# "key": "modulus_loss",
# "key": "rho_z",
# "type": "value",
# "value": 5.0,
# "unit": "GPa",
Expand Down
Loading