Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] Append() in Nullable columns causes nulls_ array to be incorrectly appended to if nested column Append() fails #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug fix] Append() in Nullable columns causes nulls_ array to be incorrectly appended to if nested column Append() fails #376

wants to merge 1 commit into from

Commits on Jun 30, 2024

  1. bug fix in Append() for nullable columns 

    If Append() of the nested column fails, the nulls column will be incremented despite nothing being appended.

It will also be marked as not null, causing an error to be thrown if this new "fake" value in the column is accessed later.

this fixes that by moving the appending of the nulls markers to the end of the Append() operation of the nested column
    @moaazassali
    moaazassali committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    ea59e1f View commit details
    Browse the repository at this point in the history