Update CODEOWNERS #42
Conversation
Looks like every connector that's being generated using this template, could end up in the GitHub organization `conduitio-labs` which means will bring an incorrect `CODEOWNER`. This PR should accommodate for both. Once moved to either organization, the one that doesn't apply could be removed.
| @@ -1,3 +1,4 @@ | |||
| # Define code owners (individuals or teams that are responsible for code in this repository) | |||
| # More about code owners at https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners | |||
| * @ConduitIO/conduit-core | |||
There was a problem hiding this comment.
This CODEOWNERS file is actually meant for the template repo itself. Every time we open a PR here (like this one) it will ask for a review from the conduit-core team, so we still need it here. In setup.sh we even remove this line, because the assumption is that the developer will set up their own file if needed. So I'm not sure how to make this better - maybe something in setup.sh that asks the user about the codeowners?
There was a problem hiding this comment.
@lovromazgon oh damn! I didn't know the existence of this setup.sh 🙈 .
I was looking for a way to make sure new transferred repositories kept the right CODEOWNERS. Not sure I know the historic reasons for those other repositories to have the wrong one, but this PR is definitely not the right way to prevent it. I'll close it for now. Thanks for the pointer.
Description
Looks like every connector that's being generated using this template, could end up in the GitHub organization
conduitio-labswhich means will bring an incorrectCODEOWNER.This PR should accommodate for both. Once moved to either organization, the one that doesn't apply could be removed.
An alternative (which is the most likely situation) is to actually move this template to conduitio-labs and then the core team update to the right CODEOWNER.
Quick checks: