Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CODEOWNERS file is actually meant for the template repo itself. Every time we open a PR here (like this one) it will ask for a review from the conduit-core team, so we still need it here. In
setup.sh
we even remove this line, because the assumption is that the developer will set up their own file if needed. So I'm not sure how to make this better - maybe something insetup.sh
that asks the user about the codeowners?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lovromazgon oh damn! I didn't know the existence of this
setup.sh
🙈 .I was looking for a way to make sure new transferred repositories kept the right CODEOWNERS. Not sure I know the historic reasons for those other repositories to have the wrong one, but this PR is definitely not the right way to prevent it. I'll close it for now. Thanks for the pointer.