Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #42

Closed
wants to merge 1 commit into from
Closed

Update CODEOWNERS #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Define code owners (individuals or teams that are responsible for code in this repository)
# More about code owners at https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
* @ConduitIO/conduit-core
Copy link
Member

@lovromazgon lovromazgon Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CODEOWNERS file is actually meant for the template repo itself. Every time we open a PR here (like this one) it will ask for a review from the conduit-core team, so we still need it here. In setup.sh we even remove this line, because the assumption is that the developer will set up their own file if needed. So I'm not sure how to make this better - maybe something in setup.sh that asks the user about the codeowners?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovromazgon oh damn! I didn't know the existence of this setup.sh 🙈 .

I was looking for a way to make sure new transferred repositories kept the right CODEOWNERS. Not sure I know the historic reasons for those other repositories to have the wrong one, but this PR is definitely not the right way to prevent it. I'll close it for now. Thanks for the pointer.

* @conduitio-labs/conduit-core