Fix serializing multiple licenses to XML #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A couple of tests are still broken, mostly because some empty I could not figure out a good way to inject the namespace into the XmlWriter. If you have a more elegant solution, let me know. |
Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
andreas-hilti
force-pushed
the
fix/serialize_licenses
branch
from
a7876a1
to
6c0c4f1
Compare
Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
Signed-off-by: andreas hilti <andreas.hilti@bluewin.ch>
This was referenced May 26, 2024
Merged
|
merged via #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix serializing multiple licenses to XML
Aims to address the issue raised in #187.