Fix to Value of dropdown changes automatically on item submission page

[hugo-escire]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Value of dropdown changes automatically on item submission page. #2145

Description

On item submission page, the value of first dropdown automatically resets to the first value present in the dropdown on pressing "enter" in any of the textbox. Now this has been fixed.

Instructions for Reviewers

1. Go to Item submission page
2. Select book from “type” dropdown. (Select any value other than first value in dropdown)
3. Click on text box with label as "identifier" and then press enter.

List of changes in this PR:

• First, I change the event that triggers the OnSelect function, before it was onClick, now it is "keydown.enter". I made this change because the bug was in the click event, when the detect change was made to some other input (as explained in issue 2145), the click event was triggered on the dropdown by setting the first default value. But currently the "mousedown" event is handled, which seamlessly replaces the click event. Added the "keydown.enter" because trying to interact via the keyboard (and since the click event was not there) failed to fire the event.
• Second, in the test I had to change the click event to "mousedown", since this is now the event that triggers the onSelect function.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[alanorth]

Thanks @hugo-escire. This is a strange bug that must have been tricky to track down! I was able to reproduce it following the simple instructions. The patch works as described.

I don't fully understand the JavaScript code so I will let someone else inspect and approve.

[alanorth]

On second thought, after reading the explanation of the changes and reviewing the code this change seems straightforward. And, as I noted last week, the patch works as advertised, so I will merge this.

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix to Value of dropdown changes automatically on item submission page #2476