Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to Value of dropdown changes automatically on item submission page #2432

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Fix to Value of dropdown changes automatically on item submission page #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6513059
🐛 Fix Value of dropdown changes automatically on item submission page
hugo-escire Aug 13, 2023
25479e1
✅change test event, click by mousedown on dynamic-scrollable-dropdown…
hugo-escire Aug 13, 2023
539edfa
Merge branch 'DSpace:main' into issue/2145
hugo-escire Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

<button class="dropdown-item disabled" *ngIf="optionsList && optionsList.length == 0">{{'form.no-results' | translate}}</button>
<button class="dropdown-item collection-item text-truncate" *ngFor="let listEntry of optionsList"
(click)="onSelect(listEntry); sdRef.close()" (mousedown)="onSelect(listEntry); sdRef.close()"
(keydown.enter)="onSelect(listEntry); sdRef.close()" (mousedown)="onSelect(listEntry); sdRef.close()"
title="{{ listEntry.display }}" role="option"
[attr.id]="listEntry.display == (currentValue|async) ? ('combobox_' + id + '_selected') : null">
{{inputFormatter(listEntry)}}
Expand Down
7 changes: 4 additions & 3 deletions ...-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,15 @@ describe('Dynamic Dynamic Scrollable Dropdown component', () => {
let de: any = scrollableDropdownFixture.debugElement.query(By.css('input.form-control'));
let btnEl = de.nativeElement;

btnEl.click();
const mousedownEvent = new MouseEvent('mousedown');

btnEl.dispatchEvent(mousedownEvent);
scrollableDropdownFixture.detectChanges();

de = scrollableDropdownFixture.debugElement.queryAll(By.css('button.dropdown-item'));
btnEl = de[0].nativeElement;

btnEl.click();

btnEl.dispatchEvent(mousedownEvent);
scrollableDropdownFixture.detectChanges();

expect((scrollableDropdownComp.model as any).value).toEqual(selectedValue);
Expand Down
Loading