refactor(slac): remove dead code #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-w50
requested review from
corneliusclaussen,
SebaLukas,
Pietfried and
hikinggrass
as code owners
hikinggrass
approved these changes
Jun 11, 2024
corneliusclaussen
approved these changes
Jun 11, 2024
- the EvseSlac module had config options for `evse_id` and `nid`, which both are not used at all - the specification states, that the `nid` needs to be derived from the `nmk`, and hence shouldn't be set directly anyway - furthermore, the specification states, that the `evse_id` should have the value of `0x00` (which the current implementation also does) - the same is true for the option `ev_id` in the EvSlac module - all of these, therefore, unused options have been removed - NOTE: the JsSlacSimulator still has these config options and might need to be changed too Signed-off-by: aw <aw@pionix.de>
corneliusclaussen
force-pushed
the
refactor/slac_dead_code
branch
from
7c8972a
to
cf09a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evse_idandnid, which both are not used at allnidneeds to be derived from thenmk, and hence shouldn't be set directly anywayevse_idshould have the value of0x00(which the current implementation also does)ev_idin the EvSlac moduleDescribe your changes
Issue ticket number and link
Checklist before requesting a review