Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(slac): remove dead code #717

Merged
merged 1 commit into from
Jun 11, 2024
+0 −34
Merged

refactor(slac): remove dead code #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions modules/EvSlac/main/ev_slacImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,6 @@ namespace module {
namespace main {

void ev_slacImpl::init() {
// validate config settings
if (config.ev_id.length() != slac::defs::STATION_ID_LEN) {
EVLOG_AND_THROW(
Everest::EverestConfigError(fmt::format("The EVSE id config needs to be exactly {} octets (got {}).",
slac::defs::STATION_ID_LEN, config.ev_id.length())));
}

// setup evse fsm thread
std::thread(&ev_slacImpl::run, this).detach();
}
Expand Down
1 change: 0 additions & 1 deletion modules/EvSlac/main/ev_slacImpl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ namespace main {

struct Conf {
std::string device;
std::string ev_id;
int set_key_timeout_ms;
};

Expand Down
4 changes: 0 additions & 4 deletions modules/EvSlac/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ provides:
description: Ethernet device used for PLC.
type: string
default: eth1
ev_id:
description: EVSE id - 17 octets.
type: string
default: PIONIX_SAYS_HELLO
set_key_timeout_ms:
description: Timeout for CM_SET_KEY.REQ. Default works for QCA7000/QCA7005/CG5317.
type: integer
Expand Down
12 changes: 0 additions & 12 deletions modules/EvseSlac/main/slacImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,6 @@ static std::string mac_to_ascii(const std::string& mac_binary) {
}

void slacImpl::init() {
// validate config settings
if (config.evse_id.length() != slac::defs::STATION_ID_LEN) {
EVLOG_AND_THROW(
Everest::EverestConfigError(fmt::format("The EVSE id config needs to be exactly {} octets (got {}).",
slac::defs::STATION_ID_LEN, config.evse_id.length())));
}

if (config.nid.length() != slac::defs::NID_LEN) {
EVLOG_AND_THROW(Everest::EverestConfigError(fmt::format(
"The NID config needs to be exactly {} octets (got {}).", slac::defs::NID_LEN, config.nid.length())));
}

// setup evse fsm thread
std::thread(&slacImpl::run, this).detach();
}
Expand Down
2 changes: 0 additions & 2 deletions modules/EvseSlac/main/slacImpl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ namespace main {

struct Conf {
std::string device;
std::string evse_id;
std::string nid;
int number_of_sounds;
bool ac_mode_five_percent;
int set_key_timeout_ms;
Expand Down
8 changes: 0 additions & 8 deletions modules/EvseSlac/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@ provides:
description: Ethernet device used for PLC.
type: string
default: eth1
evse_id:
description: EVSE id - 17 octets.
type: string
default: PIONIX_SAYS_HELLO
nid:
description: NID (Network Identification Key) - 7 octets.
type: string
default: pionix!
number_of_sounds:
description: SLAC number of sounds.
type: integer
Expand Down
Loading