Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry Policy for Jmx Connection #700 #710

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Retry Policy for Jmx Connection #700 #710

merged 1 commit into from
Sep 10, 2024

Conversation

SajidRiaz138
Copy link
Contributor

No description provided.

@SajidRiaz138 SajidRiaz138 marked this pull request as ready for review September 5, 2024 17:39
@SajidRiaz138 SajidRiaz138 requested a review from a team as a code owner September 5, 2024 17:39
jwaeab
jwaeab reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@jwaeab jwaeab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

  • Test negatives; no config set, misspelling eetc
  • Add test cases with other values; start delay longer than max, initial longer than fixed etc

...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
.../main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/RetryBackoffStrategy.java Outdated Show resolved Hide resolved
...main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/RetrySchedulerService.java Outdated Show resolved Hide resolved
...main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/RetrySchedulerService.java Outdated Show resolved Hide resolved
...main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/RetrySchedulerService.java Outdated Show resolved Hide resolved
...main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/RetrySchedulerService.java Outdated Show resolved Hide resolved
application/src/main/resources/ecc.yml Outdated Show resolved Hide resolved
VictorCavichioli
VictorCavichioli requested changes Sep 9, 2024
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
...ava/com/ericsson/bss/cassandra/ecchronos/application/config/connection/ConnectionConfig.java Outdated Show resolved Hide resolved
...ericsson/bss/cassandra/ecchronos/application/config/connection/DistributedJmxConnection.java Outdated Show resolved Hide resolved
...ericsson/bss/cassandra/ecchronos/application/config/connection/DistributedJmxConnection.java Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Outdated Show resolved Hide resolved
...va/com/ericsson/bss/cassandra/ecchronos/application/config/connection/RetryPolicyConfig.java Show resolved Hide resolved
@SajidRiaz138 SajidRiaz138 mentioned this pull request Sep 9, 2024
Merged
Retry Policy for Jmx Connection Ericsson#700
c90ca1f 
- Retry Policy for jmx connection
- Read all nodes statuses from nodes_sync table
- Filter out all node with unavailable status
- Retry to attempt jmx connection for unavailable nodes
- If connection successful add connection and change
status to available in table.
- If connection failed after given retry attempts, change
status to unreachable in table.
- This is schedule service that would execute after given
fix delay. By default it would run after every 24 hour and
scan the table.
@tommystendahl tommystendahl merged commit def5330 into Ericsson:agent/master Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwaeab jwaeab jwaeab approved these changes

@tommystendahl tommystendahl Awaiting requested review from tommystendahl

@VictorCavichioli VictorCavichioli Awaiting requested review from VictorCavichioli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SajidRiaz138 @VictorCavichioli @jwaeab @tommystendahl