Add cmake option DISABLE_CLANG_PRESERVE_ALL #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces disabling use of __attribute__((preserve_all)). Until CI uses clang17, where this attribute was added, instcountci fails when FEX is compiled with clang>=17.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Feb 2, 2024
This is used for instcountci to ensure instruction counts don't change when a compiler supports this feature or not. Always runtime disable when running in instcountci. CMake option from FEX-Emu#3394 can still be useful so leaving that in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces disabling use of attribute((preserve_all)). Until CI uses clang17, where this attribute was added, instcountci fails when FEX is compiled with clang>=17.