Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shiny-cromwell v1.2.0 Updates #163

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

shiny-cromwell v1.2.0 Updates #163

wants to merge 81 commits into from

Conversation

tefirman
Copy link
Collaborator

@tefirman tefirman commented Oct 28, 2024 •
edited
Loading

Description

  • Changing over shiny app framework to bslib (@sckott and @codebeaker in #129, #162)
    • Cleaner and more modern-looking interface, improved usability for researchers
    • Updated version of bootstrap, easier to use from a programming standpoint
  • Updating base image of R in Dockerfile (@dtenenba in #143)
  • Removing unnecessary code (@sckott in #149)

Related Issues

Testing & Examples

  • See links to individual PR's listed above

sckott and others added 30 commits August 12, 2024 16:16
@sckott
started playing with bslib as replacement for shinydashboard and frie…
19085ea 
…nds #49
@sckott
always use the same port for now since auto watch for changes is not …
324a26e 
…working
@sckott
change buttons to btn-sm
ac598f5
@sckott
change submission page output to a list of workflow id and status
043450c
@sckott
wip on bslib conversion #49
dceed4e
@sckott
Merge branch 'dev' into bslib
162024e
@sckott
install bsicons in docker file
7f19f6b
@dtenenba
test commit
2d9a62f
@dtenenba
add code to deploy review image
f9278a0
@tefirman
Fixing tab name on welcome page
fe693e2
@sckott
merge from dev
7ede7c2
@sckott
install bslib in dockerfile
aea434d
@sckott
add details tab and fix linking from details tab to tracking tab
5a40346
@sckott
clean up tracking tab: cleaner design, fit to page, controls moved to…
2d845d4 
… sidebar, use htmltools pkg
@sckott
PROOF servers tab: use bslib tooltips; fix styling on proof servers page
fe3f047
@sckott
add js libs back into the head elements of pages
945e8cc
@sckott
remove old wdl and viewer tabs
6e108c2
@sckott
fix linking to and from the job details tab
0798b2e
@sckott
merge from dev
500a2fb
@sckott
significant rearrangement of content in the app
6b2c76e 
- changed main tracking page to focus on metadata covering all workflows
- main tracking page: using bootstrap cards now instead of a table
- main tracking page: data now loads upon logging in and filters are client side
- main tracking page: load data for 60 days by deafult, and not configureable for now
- from main tracking page can now click for Details for a single workflow to go to details tab
- new workflow details tab with 8 tabs with stuff specific to each workflow
@sckott
add parsedate pkg to Dockerfile
d4531be
@sckott
fix workflow details workflow ID UI to be empty without a selected wo…
2f3a290 
…rkflow
@sckott
a bunch of changes following sonus study
226eb7b
@dtenenba
run tests before trying to access app
61d23f4
@sckott
fix date filtering for tracking page: add times to dates
89bb83a
@sckott
change Running badge color in workflow cards to match other colors
be08f20
@sckott
use random ids for labels if not supplied; show workflow labels on wo…
e1bce98 
…rkflow details page and short UUID
@sckott
change workflow description tab in workflow details to be a list inse…
36a86ce 
…tad of table, still work to do on it
@tefirman
Adding dummy update to trigger GitHub action
97df769
@dtenenba
use R-4.4 base image
1e11983
@sckott
Merge pull request #161 from FredHutch/fix-filtering-problems
a71dd01 
Fix filtering problems
@sckott
Revert "Merge pull request #148 from FredHutch/workflow-name-select"
f3bc010 
and revert merge PR #161 from FredHutch/fix-filtering-problems

This reverts commit 1caf5cd, reversing
changes made to 6a5cde0.

And reverts commit a71dd01, reversing
changes made to 6a5cde0
@sckott
fix #154 navbar changes
b962c51 
- add logo in upper left
- black navbar
- click proof to get to landing page
- resources tab name change and placement
@sckott
fix #155 change "this" to proof and what the acronym means
8f69367
@sckott
#156 changed headings on help page and added email and open an issue …
1742199 
…lines
@sckott
fix #156 - add back code last date change, commit sha and link to repo
127263c
@sckott
#157 server page: make Notes consistent, use bootstrap alerts for the…
833ba35 
…m all
@sckott
fix #157 add spinner for loading server details on server page
108b116
@sckott
#158 submit pages changes:
50e8ae3 
- make submit button green when enabled
- disbale submit button until a wdl is uploaded (other files are optional so arent related to disabled state)
- move submission result under submit button
- unrelated: disable start server button on server page when status is running
@sckott
undo addition of server spinner in 108b116 for now, need to refine it…
95cb8bd 
… more
@sckott
#159 track workflow page: each card
0278065 
- move workflow id to bottom left of card
- move name and labels to top left of card
@sckott
#159 added spinner for workflow details buttons on each click, and re…
57064c2 
…set after loading details page is done, removed icon
@sckott
possible fix for 401 error
0e1a4d0
@sckott
change server start disable toggle - run toggle only if logged in and…
1392c9c 
… server up
@sckott
move cromwellProofStatusData call in proofStatusTextGenerator within …
c3f5439 
…if logged in block
@sckott
fix #159 add spinner loading to cards on tracking page
1e5af36
@sckott
#158 submit page, disable submit button on page load, and disable but…
37ac9a6 
…ton after result returned
@sckott
#160 move troubleshoot tab into workflow details tab
a80d551
@sckott
clean up workflow details page to have each panel be its own R object
92c3de9
@sckott
#160 rework header of workflow details, name and labels on left, ID o…
d03bdba 
…n right
@sckott
#160 workflow details work
c3606d1 
- add spinners to most tabs in workflow details tab
- add alert to workflow options tab when theres no data to show
- clean up some code
@sckott
code cleanup, remove an old file, and remove focus_id stuff
6115cc0
@sckott
Copy link
Collaborator

sckott commented Oct 29, 2024

@tefirman i'm about to ask for feedback on #162 tomorrow morning - include that here as well?

@tefirman
Copy link
Collaborator Author

@sckott -- 100%, just added #162 and its related issues above. Let me know when you're ready for feedback!

@sckott
Copy link
Collaborator

sckott commented Oct 29, 2024

thanks, that PR is ready to look at now

@sckott
Copy link
Collaborator

sckott commented Oct 30, 2024

@tefirman bits and bobs in PR #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tefirman @sckott @dtenenba