Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny-cromwell v1.2.0 Updates #163

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

shiny-cromwell v1.2.0 Updates #163

wants to merge 81 commits into from

Conversation

tefirman
Copy link
Collaborator

@tefirman tefirman commented Oct 28, 2024

Description

  • Changing over shiny app framework to bslib (@sckott and @codebeaker in #129, #162)
    • Cleaner and more modern-looking interface, improved usability for researchers
    • Updated version of bootstrap, easier to use from a programming standpoint
  • Updating base image of R in Dockerfile (@dtenenba in #143)
  • Removing unnecessary code (@sckott in #149)

Related Issues

Testing & Examples

  • See links to individual PR's listed above

sckott and others added 30 commits August 12, 2024 16:16
- changed main tracking page to focus on metadata covering all workflows
- main tracking page: using bootstrap cards now instead of a table
- main tracking page: data now loads upon logging in and filters are client side
- main tracking page: load data for 60 days by deafult, and not configureable for now
- from main tracking page can now click for Details for a single workflow to go to details tab
- new workflow details tab with 8 tabs with stuff specific to each workflow
and revert merge PR #161 from FredHutch/fix-filtering-problems

This reverts commit 1caf5cd, reversing
changes made to 6a5cde0.

And reverts commit a71dd01, reversing
changes made to 6a5cde0
- add logo in upper left
- black navbar
- click proof to get to landing page
- resources tab name change and placement
- make submit button green when enabled
- disbale submit button until a wdl is uploaded (other files are optional so arent related to disabled state)
- move submission result under submit button
- unrelated: disable start server button on server page when status is running
- move workflow id to bottom left of card
- move name and labels to top left of card
…set after loading details page is done, removed icon
- add spinners to most tabs in workflow details tab
- add alert to workflow options tab when theres no data to show
- clean up some code
@sckott
Copy link
Collaborator

sckott commented Oct 29, 2024

@tefirman i'm about to ask for feedback on #162 tomorrow morning - include that here as well?

@tefirman
Copy link
Collaborator Author

@sckott -- 100%, just added #162 and its related issues above. Let me know when you're ready for feedback!

@sckott
Copy link
Collaborator

sckott commented Oct 29, 2024

thanks, that PR is ready to look at now

@sckott
Copy link
Collaborator

sckott commented Oct 30, 2024

@tefirman bits and bobs in PR #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment