Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shiny-cromwell v1.2.0 Updates #163

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

shiny-cromwell v1.2.0 Updates #163

wants to merge 81 commits into from

Commits on Aug 12, 2024

  1. started playing with bslib as replacement for shinydashboard and frie… 

    …nds #49
    @sckott
    sckott committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    19085ea View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. always use the same port for now since auto watch for changes is not … 

    …working
    @sckott
    sckott committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    324a26e View commit details
    Browse the repository at this point in the history

  2. change buttons to btn-sm

    @sckott
    sckott committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ac598f5 View commit details
    Browse the repository at this point in the history

  3. change submission page output to a list of workflow id and status

    @sckott
    sckott committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    043450c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. wip on bslib conversion #49

    @sckott
    sckott committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    dceed4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into bslib

    @sckott
    sckott committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    162024e View commit details
    Browse the repository at this point in the history

  3. install bsicons in docker file

    @sckott
    sckott committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7f19f6b View commit details
    Browse the repository at this point in the history

  4. test commit

    @dtenenba
    dtenenba committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2d9a62f View commit details
    Browse the repository at this point in the history

  5. add code to deploy review image

    @dtenenba
    dtenenba committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f9278a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Fixing tab name on welcome page

    @tefirman
    tefirman committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fe693e2 View commit details
    Browse the repository at this point in the history

  2. merge from dev

    @sckott
    sckott committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7ede7c2 View commit details
    Browse the repository at this point in the history

  3. install bslib in dockerfile

    @sckott
    sckott committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    aea434d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. add details tab and fix linking from details tab to tracking tab

    @sckott
    sckott committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5a40346 View commit details
    Browse the repository at this point in the history

  2. clean up tracking tab: cleaner design, fit to page, controls moved to… 

    … sidebar, use htmltools pkg
    @sckott
    sckott committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2d845d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. PROOF servers tab: use bslib tooltips; fix styling on proof servers page

    @sckott
    sckott committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    fe3f047 View commit details
    Browse the repository at this point in the history

  2. add js libs back into the head elements of pages

    @sckott
    sckott committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    945e8cc View commit details
    Browse the repository at this point in the history

  3. remove old wdl and viewer tabs

    @sckott
    sckott committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6e108c2 View commit details
    Browse the repository at this point in the history

  4. fix linking to and from the job details tab

    @sckott
    sckott committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0798b2e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. merge from dev

    @sckott
    sckott committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    500a2fb View commit details
    Browse the repository at this point in the history

  2. significant rearrangement of content in the app 

    - changed main tracking page to focus on metadata covering all workflows
- main tracking page: using bootstrap cards now instead of a table
- main tracking page: data now loads upon logging in and filters are client side
- main tracking page: load data for 60 days by deafult, and not configureable for now
- from main tracking page can now click for Details for a single workflow to go to details tab
- new workflow details tab with 8 tabs with stuff specific to each workflow
    @sckott
    sckott committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6b2c76e View commit details
    Browse the repository at this point in the history

  3. add parsedate pkg to Dockerfile

    @sckott
    sckott committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d4531be View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. fix workflow details workflow ID UI to be empty without a selected wo… 

    …rkflow
    @sckott
    sckott committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2f3a290 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. a bunch of changes following sonus study

    @sckott
    sckott committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    226eb7b View commit details
    Browse the repository at this point in the history

  2. run tests before trying to access app

    @dtenenba
    dtenenba committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    61d23f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. fix date filtering for tracking page: add times to dates

    @sckott
    sckott committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    89bb83a View commit details
    Browse the repository at this point in the history

  2. change Running badge color in workflow cards to match other colors

    @sckott
    sckott committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    be08f20 View commit details
    Browse the repository at this point in the history

  3. use random ids for labels if not supplied; show workflow labels on wo… 

    …rkflow details page and short UUID
    @sckott
    sckott committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e1bce98 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. change workflow description tab in workflow details to be a list inse… 

    …tad of table, still work to do on it
    @sckott
    sckott committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    36a86ce View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Adding dummy update to trigger GitHub action

    @tefirman
    tefirman committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    97df769 View commit details
    Browse the repository at this point in the history

  2. use R-4.4 base image

    @dtenenba
    dtenenba committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1e11983 View commit details
    Browse the repository at this point in the history

  3. change tracking page intro buttons to text

    @sckott
    sckott committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0bc483f View commit details
    Browse the repository at this point in the history

  4. install testthat

    @dtenenba
    dtenenba committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    187045e View commit details
    Browse the repository at this point in the history

  5. change status bootstrap buttons on each card on tracking page to just… 

    … text
    @sckott
    sckott committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ae2000e View commit details
    Browse the repository at this point in the history

  6. install shinylogs

    @dtenenba
    dtenenba committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c2e3f17 View commit details
    Browse the repository at this point in the history

  7. remove --no-cache

    @dtenenba
    dtenenba committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6bbce73 View commit details
    Browse the repository at this point in the history

  8. install binary R packages

    @dtenenba
    dtenenba committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c43176c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'bslib' into r-44-test

    @tefirman
    tefirman authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fe18349 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #143 from FredHutch/r-44-test 

    R 44 test
    @tefirman
    tefirman authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2ac97a5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #129 from FredHutch/bslib 

    Change over shiny app framework to bslib?
    @tefirman
    tefirman authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    26a28d8 View commit details
    Browse the repository at this point in the history

  4. remove unused code

    @sckott
    sckott committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    87b364e View commit details
    Browse the repository at this point in the history

  5. add links to each page from the get started welcome page bulleted list

    @sckott
    sckott committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    73de7ec View commit details
    Browse the repository at this point in the history

  6. remove more unused cod

    @sckott
    sckott committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    71ec8af View commit details
    Browse the repository at this point in the history

  7. remove abort card from troubleshoot page; add abort button to each ca… 

    …rd on tracking page
    @sckott
    sckott committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    41a5c4d View commit details
    Browse the repository at this point in the history

  8. remove unused ui components

    @sckott
    sckott committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ba16632 View commit details
    Browse the repository at this point in the history

  9. fix #132 remove DIY cromwell login button if PROOF logged in; also ad… 

    …d user icon for username when logged in
    @sckott
    sckott committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    086c3c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. update users proof url in cookies db upon proof server start and dele… 

    …te - relates to #145 #119 #114 getwilds/proof#9
    @sckott
    sckott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    96ba467 View commit details
    Browse the repository at this point in the history

  2. add more statuses to top of tracking page, swap a few colors, simplif… 

    …y code
    @sckott
    sckott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d467803 View commit details
    Browse the repository at this point in the history

  3. #112 partial name match in workflow name search - not done yet

    @sckott
    sckott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    212a4e5 View commit details
    Browse the repository at this point in the history

  4. remove value param in selectInput

    @sckott
    sckott committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    19dd91d View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. rework cards updating in backend, add label text inputs

    @sckott
    sckott committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b619c84 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. fix #146 old cold clean up 

    - remove old about.md page, rename about2 to about
- remove sidebar.R - old shinydashboard code
- tab-tracking: remove commented out code
- tab-troubleshoot: remove commented out code
- tab-workflow_details: remove commented out code
- server and other files: move around pkg imports to where they are used; remove commented out code
    @sckott
    sckott committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1f0c6ec View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge pull request #149 from FredHutch/clean-out-old-code 

    old cold clean up
    @tefirman
    tefirman authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6a5cde0 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge pull request #148 from FredHutch/workflow-name-select 

    Filtering workflow name improvements and addition of labels filtering
    @tefirman
    tefirman authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1caf5cd View commit details
    Browse the repository at this point in the history

  2. remove debugging print statements; fix observeEvent for filters to tr… 

    …igger on cards refresh event; make tracking reset also reset labels input
    @sckott
    sckott committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ec1df5e View commit details
    Browse the repository at this point in the history

  3. fix sort in filters, wasnt wired up to actually work yet

    @sckott
    sckott committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7836235 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #161 from FredHutch/fix-filtering-problems 

    Fix filtering problems
    @sckott
    sckott authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a71dd01 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Revert "Merge pull request #148 from FredHutch/workflow-name-select" 

    and revert merge PR #161 from FredHutch/fix-filtering-problems

This reverts commit 1caf5cd, reversing
changes made to 6a5cde0.

And reverts commit a71dd01, reversing
changes made to 6a5cde0
    @sckott
    sckott committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f3bc010 View commit details
    Browse the repository at this point in the history

  2. fix #154 navbar changes 

    - add logo in upper left
- black navbar
- click proof to get to landing page
- resources tab name change and placement
    @sckott
    sckott committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b962c51 View commit details
    Browse the repository at this point in the history

  3. fix #155 change "this" to proof and what the acronym means

    @sckott
    sckott committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8f69367 View commit details
    Browse the repository at this point in the history

  4. #156 changed headings on help page and added email and open an issue … 

    …lines
    @sckott
    sckott committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1742199 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. fix #156 - add back code last date change, commit sha and link to repo

    @sckott
    sckott committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    127263c View commit details
    Browse the repository at this point in the history

  2. #157 server page: make Notes consistent, use bootstrap alerts for the… 

    …m all
    @sckott
    sckott committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    833ba35 View commit details
    Browse the repository at this point in the history

  3. fix #157 add spinner for loading server details on server page

    @sckott
    sckott committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    108b116 View commit details
    Browse the repository at this point in the history

  4. #158 submit pages changes: 

    - make submit button green when enabled
- disbale submit button until a wdl is uploaded (other files are optional so arent related to disabled state)
- move submission result under submit button
- unrelated: disable start server button on server page when status is running
    @sckott
    sckott committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    50e8ae3 View commit details
    Browse the repository at this point in the history

  5. undo addition of server spinner in 108b116 for now, need to refine it… 

    … more
    @sckott
    sckott committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    95cb8bd View commit details
    Browse the repository at this point in the history

  6. #159 track workflow page: each card 

    - move workflow id to bottom left of card
- move name and labels to top left of card
    @sckott
    sckott committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0278065 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. #159 added spinner for workflow details buttons on each click, and re… 

    …set after loading details page is done, removed icon
    @sckott
    sckott committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    57064c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. possible fix for 401 error

    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0e1a4d0 View commit details
    Browse the repository at this point in the history

  2. change server start disable toggle - run toggle only if logged in and… 

    … server up
    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1392c9c View commit details
    Browse the repository at this point in the history

  3. move cromwellProofStatusData call in proofStatusTextGenerator within … 

    …if logged in block
    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c3f5439 View commit details
    Browse the repository at this point in the history

  4. fix #159 add spinner loading to cards on tracking page

    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1e5af36 View commit details
    Browse the repository at this point in the history

  5. #158 submit page, disable submit button on page load, and disable but… 

    …ton after result returned
    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    37ac9a6 View commit details
    Browse the repository at this point in the history

  6. #160 move troubleshoot tab into workflow details tab

    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a80d551 View commit details
    Browse the repository at this point in the history

  7. clean up workflow details page to have each panel be its own R object

    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    92c3de9 View commit details
    Browse the repository at this point in the history

  8. #160 rework header of workflow details, name and labels on left, ID o… 

    …n right
    @sckott
    sckott committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d03bdba View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. #160 workflow details work 

    - add spinners to most tabs in workflow details tab
- add alert to workflow options tab when theres no data to show
- clean up some code
    @sckott
    sckott committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c3606d1 View commit details
    Browse the repository at this point in the history

  2. code cleanup, remove an old file, and remove focus_id stuff

    @sckott
    sckott committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6115cc0 View commit details
    Browse the repository at this point in the history

  3. #160 workflow details - add no data alerts to tabs where appropriate;… 

    … make buttons a reasonable size
    @sckott
    sckott committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a079cef View commit details
    Browse the repository at this point in the history

  4. make login button green and add spinner to login modal; FH logo link … 

    …to fredhutch.org
    @sckott
    sckott committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8a03d23 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. bump mermaid.js to 11.4.0

    @sckott
    sckott committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    487481c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #162 from FredHutch/ui-changes 

    UI changes based on sonu user studies
    @tefirman
    tefirman authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5197a40 View commit details
    Browse the repository at this point in the history