More commands #4
Conversation
ChocolateLoverRaj
force-pushed
the
more-commands
branch
2 times, most recently
from
beb69e6
to
f7e4bae
Compare
ChocolateLoverRaj
force-pushed
the
more-commands
branch
from
ee3e0e6
to
64d21da
Compare
|
Looking good so far, let me know when you think the PR is ready for merge. Unsure if you want to add more commands or not. |
Includes a big change that needs a fd to be provided to all ec command functions
Made big changes to how the ec command function works to allow different input and output sizes at runtime instead of hard-coding max sizes. Initializes the minimum amount of memory necessary for an ec command.
This command can only be run once per reboot (I'm pretty sure) so it can be hard to debug. Luckily it worked 1st try for me.
ChocolateLoverRaj
force-pushed
the
more-commands
branch
from
95d5fef
to
1d1d30a
Compare
The same EC command is used for changing the fp mode and also just getting the fp mode.
The function can wait for any event and detect the type of the event. It has in depth Rust-safe types for the fingerprint events.
Also includes a fix for downloading templates
ChocolateLoverRaj
force-pushed
the
more-commands
branch
from
b60b361
to
6da00c5
Compare
|
@lleyton I'm done adding more commands. I think this PR is ready to merge. |
Added an async wait_event function, added get encryption status function, made some more functions use generic trait for file.
|
Thanks, I'll review it soon. Might be a bit, since I'm still OOO |
Particularly, the InterfaceReady event is useful for knowing when the FPMCU was turned on.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChocolateLoverRaj
force-pushed
the
more-commands
branch
from
a896e07
to
94f055f
Compare
| pub fn ec_cmd_set_fan_target_rpm( | ||
| file: &mut File, | ||
| rpm: u32, | ||
| fan_index: Option<u8>, | ||
| ) -> EcCmdResult<()> { |
Check warning
Code scanning / clippy
this function depends on never type fallback being () Warning
| use crate::ec_command::{ec_command_bytemuck, ec_command_with_dynamic_output_size}; | ||
| use crate::EcCmdResult; | ||
|
|
||
| pub fn console(file: &mut File, protocol_info: &EcResponseGetProtocolInfo) -> EcCmdResult<String> { |
Check warning
Code scanning / clippy
this function depends on never type fallback being () Warning
ChocolateLoverRaj
force-pushed
the
more-commands
branch
from
6facb3e
to
e497559
Compare
| pub fn set_charge_control<File: AsRawFd>( | ||
| file: &mut File, | ||
| charge_control: ChargeControl, | ||
| ) -> EcCmdResult<()> { |
Check warning
Code scanning / clippy
this function depends on never type fallback being () Warning
|
|
||
| pub fn charge_current_limit_subcommand(limit: u32) -> Result<()> { | ||
| let mut file = File::open(CROS_EC_PATH)?; | ||
| set_charge_current_limit(&mut file, ElectricCurrent::new::<milliampere>(limit.into()))?; |
Check failure
Code scanning / clippy
the trait bound f32: std::convert::From<u32> is not satisfied Error
I'll be adding more commands to this PR, but for now the board version command is ready to merge.
Fixes #1