Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move blocks between categories #265

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

IkbelTalebHssan
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan commented Oct 23, 2024

Motivation

This PR introduces functionality to move one or multiple selected blocks between different categories. This enhancement allows for smoother transitions of grouped blocks across flows, improving workflow organization and flexibility in flow management.

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub
Copy link
Contributor

yassinedorbozgithub commented Oct 31, 2024

Hi,i think that there is a possibility to split flows cross categories.
In specific case, we will a have a working flow that is not fully visible in the visual editor.

Proposed solutions :

  1. Move block(s) and delete nextBlock(s) if necessary
  2. Copy block(s) and delete moved blocks nextBlock(s)

NB: Needs to support the case when we act on two or more linked blocks

@IkbelTalebHssan IkbelTalebHssan force-pushed the 256-request-move-blocks-between-categories branch from f8edf63 to 310d9e4 Compare October 31, 2024 16:09
@IkbelTalebHssan
Copy link
Collaborator Author

Hi,i think that there is a possibility to split flows cross categories. In specific case, we will a have a working flow that is not fully visible in the visual editor.

Proposed solutions :

  1. Move block(s) and delete nextBlock(s) if necessary
  2. Copy block(s) and delete moved blocks nextBlock(s)

NB: Needs to support the case when we act on two or more linked blocks

Thanks for your feedback 🙏 I worked on the first approch ✔️ 🙏

Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment left 👏

const [qType, qEntity] = queryKey;

return (
(qType === QueryType.collection &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be specific by using qId

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Move Blocks Between Categories
3 participants