-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move blocks between categories #265
Open
IkbelTalebHssan
wants to merge
7
commits into
main
Choose a base branch
from
256-request-move-blocks-between-categories
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+187
−4
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
902596c
feat: move blocks between categories
IkbelTalebHssan 996a504
fix: remove join/split
IkbelTalebHssan 3cef49d
fix: reorder buttons
IkbelTalebHssan 9ab93f1
fix: remove refetch
IkbelTalebHssan ce20bb7
fix: remove unnecessary snippet
IkbelTalebHssan 310d9e4
fix: resolve conflicts
IkbelTalebHssan 9a4aa00
fix: predicate
IkbelTalebHssan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
* Copyright © 2024 Hexastack. All rights reserved. | ||
* | ||
* Licensed under the GNU Affero General Public License v3.0 (AGPLv3) with the following additional terms: | ||
* 1. The name "Hexabot" is a trademark of Hexastack. You may not use this name in derivative works without express written permission. | ||
* 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file). | ||
*/ | ||
|
||
import { | ||
Button, | ||
Dialog, | ||
DialogActions, | ||
DialogContent, | ||
Grid, | ||
MenuItem, | ||
Select, | ||
} from "@mui/material"; | ||
import { FC, useState } from "react"; | ||
|
||
import { DialogTitle } from "@/app-components/dialogs/DialogTitle"; | ||
import { DialogControl } from "@/hooks/useDialog"; | ||
import { useTranslate } from "@/hooks/useTranslate"; | ||
import { ICategory } from "@/types/category.types"; | ||
|
||
export interface MoveDialogProps extends DialogControl<string> { | ||
categories: ICategory[]; | ||
callback?: (newCategoryId?: string) => Promise<void>; | ||
openDialog: (data?: string) => void; | ||
} | ||
|
||
export const MoveDialog: FC<MoveDialogProps> = ({ | ||
open, | ||
callback, | ||
closeDialog, | ||
categories, | ||
}: MoveDialogProps) => { | ||
const { t } = useTranslate(); | ||
const [selectedCategoryId, setSelectedCategoryId] = useState<string>(""); | ||
const handleMove = async () => { | ||
if (selectedCategoryId && callback) { | ||
await callback(selectedCategoryId); | ||
closeDialog(); | ||
} | ||
}; | ||
|
||
return ( | ||
<Dialog open={open} fullWidth onClose={closeDialog}> | ||
<DialogTitle onClose={closeDialog}> | ||
{t("message.select_category")} | ||
</DialogTitle> | ||
<DialogContent> | ||
<Grid container direction="column" gap={2}> | ||
<Grid item> | ||
<Select | ||
value={selectedCategoryId} | ||
onChange={(e) => setSelectedCategoryId(e.target.value as string)} | ||
fullWidth | ||
displayEmpty | ||
> | ||
<MenuItem value="" disabled> | ||
{t("label.category")} | ||
</MenuItem> | ||
{categories.map((category) => ( | ||
<MenuItem key={category.id} value={category.id}> | ||
{category.label} | ||
</MenuItem> | ||
))} | ||
</Select> | ||
</Grid> | ||
</Grid> | ||
</DialogContent> | ||
<DialogActions> | ||
<Button | ||
variant="contained" | ||
onClick={handleMove} | ||
disabled={!selectedCategoryId} | ||
> | ||
{t("button.move")} | ||
</Button> | ||
<Button variant="outlined" onClick={closeDialog}> | ||
{t("button.cancel")} | ||
</Button> | ||
</DialogActions> | ||
</Dialog> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be specific by using qId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✔️