Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for various files with generic graph #278

Conversation

simonschoelly
Copy link
Contributor

@simonschoelly simonschoelly commented Jul 4, 2023

This PR changes the tests to use generic graphs for various files that were not grouped together like others.

There where no larger changes necessary to make the tests work, but a small change was necessary for bfs_parents and some type annotations in operators.jl had to be changed so that they would accept abstract graphs.

@simonschoelly simonschoelly added the do not merge Do not merge this PR (yet) label Jul 4, 2023
@simonschoelly simonschoelly self-assigned this Jul 4, 2023
@simonschoelly simonschoelly mentioned this pull request Jul 2, 2023
12 tasks
@simonschoelly simonschoelly force-pushed the test-core-algorithms-with-generic-graph branch from e15141a to ae6f665 Compare July 4, 2023 22:21
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #278 (c3a46ab) into master (d25e5d7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   97.30%   97.35%   +0.04%     
==========================================
  Files         115      115              
  Lines        6764     6759       -5     
==========================================
- Hits         6582     6580       -2     
+ Misses        182      179       -3     

@simonschoelly simonschoelly removed the do not merge Do not merge this PR (yet) label Jul 5, 2023
@simonschoelly simonschoelly force-pushed the test-core-algorithms-with-generic-graph branch from ae6f665 to cbd6c7a Compare July 5, 2023 10:37
@gdalle
Copy link
Member

gdalle commented Aug 28, 2023

Is this mergeable @simonschoelly ?

@gdalle gdalle added this to the v1.9 milestone Aug 28, 2023
@gdalle gdalle self-assigned this Aug 28, 2023
@gdalle gdalle added the enhancement New feature or request label Aug 28, 2023
@gdalle gdalle merged commit 3fea924 into JuliaGraphs:master Sep 14, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants