Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when searching the first enabled bit in a completely disabled bit array #2381

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

giomasce
Copy link
Contributor

In some conditions the bit array ends up fetching a section that doesn't exist, one past the end of the array.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for finding this and providing the fix!

I've just added a couple of changes for style consistency.

MoltenVK/MoltenVK/Utility/MVKBitArray.h Outdated Show resolved Hide resolved
MoltenVK/MoltenVK/Utility/MVKBitArray.h Outdated Show resolved Hide resolved
Clean up PR for style consistency.
@billhollings billhollings merged commit 3422ca2 into KhronosGroup:main Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants