Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2321 #2324

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Fix #2321 #2324

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74c3481
Fix #2321
julienduroure Aug 18, 2024
f616287
Merge branch 'main' into fix_2321
julienduroure Aug 30, 2024
9e3282d
Better check of GN SK
julienduroure Sep 12, 2024
005b733
Merge branch 'main' into fix_2321
julienduroure Sep 12, 2024
56679d3
Fix check
julienduroure Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ def prepare_data(self):
# even if we apply modifiers
# (For classic objects, shape keys are not preserved if we apply modifiers)
# We can check it by checking if the mesh is used by a user
if self.blender_mesh.shape_keys and self.export_settings['gltf_morph'] and self.blender_mesh.users != 0:
# But ... in case we apply modifiers with only armature, the mesh is not used by a user
# But SK are still there
if self.blender_mesh.shape_keys and self.export_settings['gltf_morph'] and \
(self.blender_mesh.users != 0 or ( self.armature is not None and self.blender_mesh.users == 0)):
self.key_blocks = get_sk_exported(self.blender_mesh.shape_keys.key_blocks)

# Fetch vert positions and bone data (joint,weights)
Expand Down
Loading