Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2321 #2324

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Fix #2321 #2324

merged 5 commits into from
Oct 31, 2024

Conversation

julienduroure
Copy link
Collaborator

Export SK when apply modifiers with only Armature modifier

@julienduroure
Fix #2321
74c3481 
Export SK when apply modifiers with only Armature modifier
@julienduroure julienduroure linked an issue Aug 18, 2024 that may be closed by this pull request
blender 4.2 cannot export shapekey with amature #2321
Closed
@julienduroure julienduroure added this to the Blender 4.2 LTS milestone Aug 18, 2024
Jontte
Jontte suggested changes Aug 28, 2024
View reviewed changes
Copy link

@Jontte Jontte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need a similar fix in gltf2_blender_gather_mesh.py:120 to make sure the names of the shape keys also get exported in the mesh extras.

@julienduroure
Copy link
Collaborator Author

Hello,
Yes, thanks to pointing this out.
I think we should find another way to discriminate cases than using users count.
This commit should be re-think differently: 1bc42a7

@julienduroure julienduroure marked this pull request as draft August 28, 2024 15:29
@julienduroure julienduroure marked this pull request as ready for review September 12, 2024 14:06
@julienduroure julienduroure changed the base branch from main to blender-v4.3-release October 3, 2024 02:20
@julienduroure julienduroure merged commit f1f8537 into blender-v4.3-release Oct 31, 2024
2 checks passed
@julienduroure julienduroure mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jontte Jontte Jontte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Blender 4.2 LTS
Development

Successfully merging this pull request may close these issues.

blender 4.2 cannot export shapekey with amature
2 participants
@julienduroure @Jontte