Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar added as prereq for build on Fedora, more details about Bazel ver… #12591

Closed
wants to merge 1 commit into from

Conversation

useidel
Copy link

@useidel useidel commented Feb 20, 2024

Summary

Improves documentation about how to build Kong Gateway (Bazel version in general, Fedora in particular)

…sion to be used, known issue with ccache on Fedora
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -145,6 +146,8 @@ You can follow [Managing your personal access token](https://docs.github.com/en/
# export GITHUB_TOKEN=ghp_xxxxxx_your_access_token
```

The build process is based on [Bazel](https://bazel.build/). Please make sure that you have the [required version](https://github.com/Kong/kong/blob/master/.bazelversion) installed. For more details please check out the [the build guide](https://github.com/Kong/kong/blob/master/build/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @useidel , thanks for the contribution.
We recommend using bazelisk in docs to automatically manage bazel versions. Manual intervetion is not needed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fffonion should this PR be closed, or is there any other change that should be added to the docs?

@AndyZhang0707
Copy link
Collaborator

@fffonion shall we close this PR?

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Mar 29, 2024
@jschmid1 jschmid1 closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) build/bazel core/docs size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants