Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar added as prereq for build on Fedora, more details about Bazel ver… #12591

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ dnf install \
perl-IPC-Cmd \
protobuf-devel \
unzip \
tar \
valgrind \
valgrind-devel \
zlib-devel
Expand All @@ -145,6 +146,8 @@ You can follow [Managing your personal access token](https://docs.github.com/en/
# export GITHUB_TOKEN=ghp_xxxxxx_your_access_token
```

The build process is based on [Bazel](https://bazel.build/). Please make sure that you have the [required version](https://github.com/Kong/kong/blob/master/.bazelversion) installed. For more details please check out the [the build guide](https://github.com/Kong/kong/blob/master/build/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @useidel , thanks for the contribution.
We recommend using bazelisk in docs to automatically manage bazel versions. Manual intervetion is not needed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fffonion should this PR be closed, or is there any other change that should be added to the docs?


Finally, we start the build process:

```
Expand Down
2 changes: 2 additions & 0 deletions build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
This directory contains the build system for the project.
The build system is designed to be used with the [Bazel](https://bazel.build/).
It is designed to be running on Linux without root privileges, and no virtualization technology is required.
However, you need to match exactly the version of Bazel as configured [here](https://github.com/Kong/kong/blob/master/.bazelversion).

The build system is tested on Linux (x86_64 and aarch64) and macOS (Intel chip and AppleSilicon Chip).

Expand Down Expand Up @@ -252,3 +253,4 @@ Note:

- On macOS, the build may not work with only Command Line Tools installed, you will typically see errors like `../libtool: line 154: -s: command not found`. In such case, installing Xcode should fix the issue.
- If you have configure `git` to use SSH protocol to replace HTTPS protocol, but haven't setup SSH agent, you might see errors like `error: Unable to update registry crates-io`. In such case, set `export CARGO_NET_GIT_FETCH_WITH_CLI=true` to use `git` command line to fetch the repository.
- There are problems with [ccache](https://ccache.dev/) on Fedora. You can solve this by removing the path pointing to ccache from that `PATH` variable in you shell.
Loading