Skip to content

hal: Stop exporting halpr_*() private functions and shared memory base #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BsAtHome wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hal: Stop exporting halpr_*() private functions and shared memory base #4469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/hal/hal_lib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4517,14 +4517,6 @@ static bool hal_port_compute_copy(unsigned read,
}


// hal_port_alloc() is DEPRECATED
// Access to port allocation is done by hal_set_s() on the signal that has the
// port pins connected.
int hal_port_alloc(unsigned size, hal_port_t *port)
{
return halpr_port_alloc(size, port);
}

int halpr_port_alloc(unsigned size, hal_port_t *port) {
if(!port || size < 1 || size > HAL_PORT_SIZE_MAX)
return -EINVAL;
Expand Down Expand Up @@ -5245,25 +5237,9 @@ EXPORT_SYMBOL(hal_del_funct_from_thread);
EXPORT_SYMBOL(hal_start_threads);
EXPORT_SYMBOL(hal_stop_threads);

EXPORT_SYMBOL(hal_shmem_base);
EXPORT_SYMBOL(halpr_find_comp_by_name);
EXPORT_SYMBOL(halpr_find_pin_by_name);
EXPORT_SYMBOL(halpr_find_sig_by_name);
EXPORT_SYMBOL(halpr_find_param_by_name);
EXPORT_SYMBOL(halpr_find_thread_by_name);
EXPORT_SYMBOL(halpr_find_funct_by_name);
EXPORT_SYMBOL(halpr_find_comp_by_id);

EXPORT_SYMBOL(halpr_find_pin_by_owner);
EXPORT_SYMBOL(halpr_find_param_by_owner);
EXPORT_SYMBOL(halpr_find_funct_by_owner);

EXPORT_SYMBOL(halpr_find_pin_by_sig);

EXPORT_SYMBOL(hal_pin_alias);
EXPORT_SYMBOL(hal_param_alias);

EXPORT_SYMBOL(hal_port_alloc);
EXPORT_SYMBOL(hal_port_read);
EXPORT_SYMBOL(hal_port_peek);
EXPORT_SYMBOL(hal_port_peek_commit);
Expand Down
12 changes: 4 additions & 8 deletions src/hal/hal_priv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,15 +525,11 @@ extern hal_funct_t *halpr_find_funct_by_owner(hal_comp_t * owner,
extern hal_pin_t *halpr_find_pin_by_sig(hal_sig_t * sig, hal_pin_t * start);


/** hal_port_alloc allocates a new empty hal_port having a buffer of size bytes.
Returns a negative value on failure. On success zero (0) is returned and
the newly allocated hal_port_t is returned in the port argument and can be
used with all other hal_port functions.
This is supposed to be private. The public function is deprecated and you
should use hal_set_s() to allocate the port once the pins are connected to
the signal.
/** halpr_port_alloc allocates a new empty hal_port having a buffer of size
bytes. Returns a negative errno value on failure. On success zero (0) is
returned and the newly allocated hal_port_t is returned in the port
argument and can be used with all other hal_port functions.
*/
extern int hal_port_alloc(unsigned size, hal_port_t *port);
int halpr_port_alloc(unsigned size, hal_port_t *port);

// Recursive HAL mutex (replaces old mutex)
Expand Down