Skip to content

hal: Deprecate old HAL API - #4472

Open
BsAtHome wants to merge 1 commit into
LinuxCNC:masterfrom
BsAtHome:halgs_deprecate-old-api
Open

hal: Deprecate old HAL API#4472
BsAtHome wants to merge 1 commit into
LinuxCNC:masterfrom
BsAtHome:halgs_deprecate-old-api

Conversation

@BsAtHome

Copy link
Copy Markdown
Contributor

The getter/setter infrastructure is in place and the next stage is to warn about any use of the old API. With this PR, the HAL header now marks the old API as deprecated, including:

  • hal_data_u
  • hal_{bit,float,u32,s32,u64,s64}_t
  • ireal_t
  • hal_pin_*_new[f]()
  • hal_pin_new()
  • hal_param_*_new[f]()
  • hal_param_new()
  • hal_param_set*()
  • hal_get_{pin,param,signal}_value_by_name()

The HAL library uses #pragma GCC diagnostic to prevent the deprecation warning from popping up when compiling the library or other when including hal.h. Only use of the old API will result in a warning.

The HAL_XXX type names, like HAL_S32 and others, are still valid and will be dealt with later. These are somewhat more involved to get streamlined and require breaking the API when done properly. A new (large) patch set will be prepared to move to the next stage before the next wave of PRs. In the meantime, the deprecation messages will inform users to start moving and prepare for what is coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant